Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2308 +/- ##
==========================================
+ Coverage 64.58% 64.63% +0.05%
==========================================
Files 367 367
Lines 33826 33837 +11
Branches 4472 4474 +2
==========================================
+ Hits 21845 21872 +27
+ Misses 11981 11965 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
# Conflicts: # dart/dynamics/FreeJoint.cpp
jslee02
added a commit
that referenced
this pull request
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #1089 by moving GenericJoint impulse-related members into the joint Aspect State so they are captured/restored by
dart::dynamics::Skeleton::getState()/setState().mVelocityChanges,mImpulses, andmConstraintImpulsestodart::dynamics::detail::GenericJointStateand updates GenericJoint/FreeJoint to use them.dart::simulation::World::reset()clear constraint impulses so stale constraint forces don't leak across independent runs.tests/integration/dynamics/test_SkeletonState.cpp.pixiinstall location (avoids intermittentpixi: command not found/ exit 127 on some runners).Closes: #1089.