Skip to content

tests: stabilize World::Cloning in asserts-enabled CI#2331

Merged
jslee02 merged 1 commit intorelease-6.16from
fix/world-cloning-deterministic
Dec 18, 2025
Merged

tests: stabilize World::Cloning in asserts-enabled CI#2331
jslee02 merged 1 commit intorelease-6.16from
fix/world-cloning-deterministic

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 18, 2025

Stabilize World.Cloning in asserts-enabled (no -DNDEBUG) CI builds.

  • Seed dart::math::Random to make the test deterministic.
  • Run the long (500-iteration) loop only in DART_BUILD_MODE_RELEASE; use the short loop otherwise (e.g., BUILD_TYPE=None in build-asserts).

Before creating a pull request

  • Format code using pixi run lint and verify with pixi run check-lint
  • Document new methods and classes
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve warnings

Before merging

  • Set milestone
  • Update CHANGELOG.md
  • Add unit tests
  • Add Python bindings (dartpy) if applicable

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.67%. Comparing base (d58fa21) to head (30f6835).
⚠️ Report is 1 commits behind head on release-6.16.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-6.16    #2331   +/-   ##
=============================================
  Coverage         58.67%   58.67%           
=============================================
  Files               384      384           
  Lines             32056    32056           
  Branches           3869     3869           
=============================================
  Hits              18809    18809           
  Misses            13247    13247           
Flag Coverage Δ
unittests 58.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 added this to the DART 6.16.2 milestone Dec 18, 2025
@jslee02 jslee02 merged commit 5afc06c into release-6.16 Dec 18, 2025
24 checks passed
@jslee02 jslee02 deleted the fix/world-cloning-deterministic branch December 18, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant