Conversation
aurexav
reviewed
Oct 9, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f417219 to
66025c1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Has it been resolved in the dev node? |
Member
Author
Yes, it has worked well in my local testing. |
aurexav
reviewed
Oct 11, 2024
Check 23009ec
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1605
The current pending RPC is problematic because it lacks the
setValidateDatainherent data provider, which is required by the parachain-system pallet. The pending RPC attempts to create extrinsics based on the inherent data and apply them before pool extrinsics, but it fails due to missing inherent data. This PR adds mock data to fulfill the validation requirements.2024-10-08 16:01:11.807 DEBUG tokio-runtime-worker eth-pending: Pending runtime API: header digest = Digest { logs: [DigestItem::PreRuntime([97, 117, 114, 97], [204, 123, 43, 17, 0, 0, 0, 0])] } 2024-10-08 16:01:11.808 ERROR tokio-runtime-worker runtime: panicked at /home/bear/.cargo/git/checkouts/polkadot-sdk-38f315c8db144fd3/5811785/cumulus/pallets/parachain-system/src/lib.rs:933:74: validation function params are always injected into inherent data; qed