Skip to content

Improve deposits migration#1636

Merged
aurexav merged 9 commits intomainfrom
x/fix
Dec 3, 2024
Merged

Improve deposits migration#1636
aurexav merged 9 commits intomainfrom
x/fix

Conversation

@aurexav
Copy link
Member

@aurexav aurexav commented Nov 29, 2024

Closes #1635.

@aurexav aurexav added C-Pallet [Component] Something about pallet C-Runtime [Component] Something about runtime labels Nov 29, 2024
Signed-off-by: Xavier Lau <x@acg.box>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@hackfisher
Copy link
Contributor

@AurevoirXavier CI failed

Signed-off-by: Xavier Lau <x@acg.box>
Signed-off-by: Xavier Lau <x@acg.box>
Signed-off-by: Xavier Lau <x@acg.box>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Signed-off-by: Xavier Lau <x@acg.box>
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

Check 6a6eaf9 crab-dev

Check runtime version

Check runtime storage

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

Check 6a6eaf9 darwinia-dev

Check runtime version

Check runtime storage

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

Check 6a6eaf9 koi-dev

Check runtime version

Check runtime storage

Pallet DarwiniaStaking
+ Entry: StorageEntryMetadata { name: "UnissuedReward", modifier: Default, ty: Plain(UntrackedSymbol { id: 6, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], docs: [" Unissued reward to Treasury."] }

Pallet Deposit
+ Entry: StorageEntryMetadata { name: "MigrationFailures", modifier: Optional, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 0, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 368, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Failures of migration.", "", " The first value is the deposits that failed to migrate,", " the second value is the type of failure."] }

Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump spec version and release a new runtime for upgrade.

Copy link
Contributor

@hujw77 hujw77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aurexav aurexav merged commit 12f4758 into main Dec 3, 2024
@aurexav aurexav deleted the x/fix branch December 3, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Pallet [Component] Something about pallet C-Runtime [Component] Something about runtime

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Filter non-zero deposit items during migration

3 participants