perf: speedup core smoke test#303
Merged
Merged
Conversation
Collaborator
Author
|
@shumkov I've set The first batch of tests progresses much faster now, but I wonder if we should rewrite the masternode list check to either use the same design with promises, or query single nodes only until one of them responds, then use that response to check all nodes. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Smoke tests were timing out without returning errors
What was done?
How Has This Been Tested?
Locally and in CI running against test build here
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only