feat: initial multi-stage deployment#520
Merged
Merged
Conversation
added 3 commits
June 25, 2023 06:13
strophy
changed the title
strophy
requested changes
Jun 26, 2023
strophy
left a comment
strophy
left a comment
Collaborator
There was a problem hiding this comment.
I'm not sure having continue.yml launch as a sub-stage of the deploy command makes sense, we either need to add a lot of error handling here (e.g. what if we deploy stage 2, but specify -i flag? I think it would be simpler to remove the case statement and just create a new top level executable script like bin/start-stage-2-services, except with a better name than that.
| register: chainlock_output | ||
| ignore_errors: true | ||
| no_log: true | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| changed_when: chainlock_output.rc == 0` | |
Contributor
Author
|
-i wouldn't affect stage2, it will just be ignored @strophy since it only actually does anything with -i in stage1
|
strophy
approved these changes
Jun 26, 2023
strophy
left a comment
strophy
left a comment
Collaborator
There was a problem hiding this comment.
Good start, let's see how this goes when we start adding functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This will make the deployment multi-staged, so we can run stage2 after chainlocks are formed. This is important because we need chainlocks in order to:
We could check quorums for the above, but since quorums are required for chainlocks I thought it better to check for chainlocks then we don't need to guess if the quorums are good.
What was done?
Changed /bin/deploy to have a new variable called STAGE where we can give it the stage we want to deploy.
Created continue.yml with a basic chainlock check
How Has This Been Tested?
devnet-yankee
Breaking Changes
None, leaving out "stage" will deploy stage1 as normal.