[WIP] Update build system to Bitcoin 0.13.2 by schinzelh · Pull Request #1692 · dashpay/dash

schinzelh · 2017-10-19T16:13:36Z

Our build system is missing some upstream commits, catching up with Bitcoin 0.13.2

Mention ARM executables in the release process documentation (these were introduced in bitcoin#8188). As well as that Linux tarballs have changed name to contain an architecture tuple, instead of `linux32`/`linux64`. Also mention that `-debug` files should not be uploaded (these were introduced in bitcoin#8167).

These add very simple sanity checks to ensure that the build/host toolchains have not changed since the last run. If they have, all ids will change and packages will be rebuilt. For more complicated usage (like parsing dpkg), HOST_ID_SALT/BUILD_ID_SALT may be used to introduce arbitrary data to the ids.

In some cases, failed downloads wouldn't trigger a fallback download attempt. Namely, checksum mismatches.

Checksums were being verified after download, but not again before extraction

Update FreeType, and change the download location to gnu.org. This is the other official download location listed on freetype.org

codablock · 2017-10-20T07:44:31Z


-0.12.1 Change log
+
+dash-cli: arguments privacy


-stdin is not available in Dash as of now. It is introduced in Bitcoin PR bitcoin#7550

Ups, that paragraph slipped in, just wanted to merge the Linux ARM part :)

codablock · 2017-10-20T07:45:38Z

+  properly in JSON RPC processing. This is no longer the case. This also affects
+  the GUI debug console.
+
+C++11 and Python 3


As far as I remember this is also not done yet in Dash

codablock · 2017-10-20T07:47:35Z

+RPC low-level changes
+----------------------
+
+- `gettxoutsetinfo` UTXO hash (`hash_serialized`) has changed. There was a divergence between


References bitcoin#7848, which is also not in Dash yet

codablock · 2017-10-20T07:47:59Z

+  32-bit and 64-bit platforms, and the txids were missing in the hashed data. This has been
+  fixed, but this means that the output will be different than from previous versions.
+
+- Full UTF-8 support in the RPC API. Non-ASCII characters in, for example,


Didn't check this, but I'd assume also not done in Dash yet.

codablock · 2017-10-20T07:49:07Z

+-------------------
+
+Various code modernizations have been done. The Dash Core code base has
+started using C++11. This means that a C++11-capable compiler is now needed for


Same. As far as I remember, this is not in Dash yet (I have many C++11 related PRs in my pile of backported PRs)

- create a script to handle split debug. This will also eventually need to check targets, and use dsymutil for osx. - update config.guess/config.sub for bdb for aarch64. - temporarily disable symbol checks for arm/aarch64 - quit renaming to linux32/linux64 and use the host directly This also adds a hack to work around an Ubuntu bug in the gcc-multilib package: https://bugs.launchpad.net/ubuntu/+source/gcc-defaults-armhf-cross/+bug/1347820 The problem is that gcc-multilib conflicts with the aarch toolchain. gcc-multilib installs a symlink that points /usr/include/asm -> /usr/include/x86_64-linux-gnu/asm. Without this link, gcc -m32 can't find asm/errno.h (and others), since /usr/include/x86_64-linux-gnu isn't in its default include path. But /usr/include/i386-linux-gnu is (though it doesn't exist on disk). So work around the problem by linking /usr/include/i386-linux-gnu/asm -> /usr/include/x86_64-linux-gnu/asm. The symlink fix is actually quite reasonable, but echoing the password into sudo is nasty, and should probably be addressed in gitian itself. It makes more sense to enable passwordless sudo for the build user by default.

C_INCLUDE_PATH and CPLUS_INCLUDE_PATH work globally as though -isystem was used for each invocation. Since that changes the build results, force a rebuild of x86 depends by adding the value to $HOST_ID_SALT.

The non-pkg-config case can't use pkg-config to check the version. Also, make sure that the check is properly guarded in the case of missing pkg-config macros.

- guard PKG_PROG_PKG_CONFIG with an m4_ifdef. If not building for windows, require it - add nops as necessary in case the ifdef reduces the if/then to nothing - AC_SUBST some missing _LIBS. These were split out over time, but not all were properly substituted. They continued to work if pkg-config is installed because it does the AC_SUBST itself

Github-Pull: bitcoin#8920 Rebased-From: 6dd3723

schinzelh · 2017-10-23T09:48:50Z

@codablock what commit are you refering to? I am adding all build system related stuff.

codablock · 2017-10-23T09:52:40Z

5c62fed

This reverts commit 5c62fed.

chaeplin · 2017-10-23T10:05:46Z

@schinzelh 2354e50 this one too.

schinzelh · 2017-10-23T10:28:00Z

@chaeplin Thats ok, it fixes #1455 which introduced a superfluous line break to the original patch - just nitpicking :)

Changes the error message from: ./autogen.sh: 9: ./autogen.sh: autoreconf: not found To: configuration failed, please install autoconf first

This fixes build with glibc 2.25 caused by conflict with CHAR_WIDTH macro from TS 18661-1:2014. Also, a patch is added to remove some redundant declarations from fcobjs.c file because they may conflict with include file autogenerated by gperf. Signed-off-by: Oleg Girko <ol@infoserver.lv>

Setting PKG_CONFIG_SYSROOT_DIR environment variable to "/" for building Qt makes pkgconf behave strange (remove "/" prefix instead of adding it). And it makes no sense to set this variable for old pkgconfig anyway. Signed-off-by: Oleg Girko <ol@infoserver.lv>

This is necessary on FreeBSD and MacOSX, at least. See bitcoin#8834 (comment)

Add missing pieces for PR #1692

UdjinM6 · 2017-12-19T11:51:02Z

Need rebase

EDIT: postponing this, @codablock probably has all this covered in his set of backports

codablock · 2018-01-19T11:26:52Z

Just verified that all backports PRs/commits from this PR are included in the 0.14 backports. We can probably close this one.

UdjinM6 · 2018-01-29T21:06:12Z

@codablock looks like c6c2c4e and 3adac27 are not part of develop though. And btw bitcoin fixed fontconfig issue via this patch bitcoin@3498a8d (2.12.6 was released later).

codablock · 2018-01-30T06:08:22Z

Missed these as I only used the list from the PR description. Cherry-picked them into #1884

UdjinM6 · 2018-01-31T10:46:19Z

Closing in fav of all already backported patches and #1884

fanquake and others added 15 commits October 19, 2017 17:49

Add aarch64 to depends .gitignore

fb83901

doc: Mention Linux ARM builds in release notes

6262b72

depends: Mention aarch64 as common cross-compile target

f92196d

depends: fix fallback downloads

ca55b1c

In some cases, failed downloads wouldn't trigger a fallback download attempt. Namely, checksum mismatches.

depends: fix "unexpected operator" error during "make download"

09aaf00

depends: qt/cctools: fix checksum checksum tests

bf7ff61

Checksums were being verified after download, but not again before extraction

Freetype 2.6.3

a3fb8d1

Update FreeType, and change the download location to gnu.org. This is the other official download location listed on freetype.org

ccache 3.2.5

ec945c9

ZeroMQ 4.1.4

d846794

Latest config.guess & config.sub

589835a

miniupnpc 2.0

afc67c9

expat 2.1.1

527f1ef

Add -stdlib=libc++ to darwin CXX flags

aa21798

schinzelh changed the title ~~[WIP] Update build system to Bitcoin 0.13~~ [WIP] Update build system to Bitcoin 0.13.2 Oct 19, 2017

codablock reviewed Oct 20, 2017

View reviewed changes

schinzelh force-pushed the update_depends branch from 7418261 to aa21798 Compare October 20, 2017 07:59

schinzelh and others added 11 commits October 20, 2017 10:00

cleanup doc/release-notes.md

7bc2a02

depends: only build qt on linux for x86_64/x86

9ac4a4b

builders: No need to set -L and --location for curl

ee13d5a

gitian: use a wrapped gcc/g++ to avoid the need for a system change

7cddce0

C_INCLUDE_PATH and CPLUS_INCLUDE_PATH work globally as though -isystem was used for each invocation. Since that changes the build results, force a rebuild of x86 depends by adding the value to $HOST_ID_SALT.

Default reference_datetime to commit author date

cc3f0e0

hardcode datetime for depends

43aca17

set correct PATH for wrappers

27599bd

Update Boost & check macros to latest serials

553e26f

Sync ax_pthread with upstream draft

1484a64

test_framework: Use different rpc_auth_pair for each node

02df786

theuni and others added 3 commits October 23, 2017 11:40

build: Fix Qt5PlatformSupport check without pkg-config

3c8e8be

The non-pkg-config case can't use pkg-config to check the version. Also, make sure that the check is properly guarded in the case of missing pkg-config macros.

Set minimum required Boost to 1.47.0

938a6fb

Github-Pull: bitcoin#8920 Rebased-From: 6dd3723

Revert "Fix relaypriority calculation error"

9d15dd4

This reverts commit 5c62fed.

knocte and others added 2 commits October 23, 2017 12:53

autogen.sh: warn about needing autoconf if autoreconf is not found

063fea5

Changes the error message from: ./autogen.sh: 9: ./autogen.sh: autoreconf: not found To: configuration failed, please install autoconf first

Ignore split-debug.sh

8d1347e

UdjinM6 added this to the 12.3 milestone Oct 23, 2017

UdjinM6 mentioned this pull request Nov 1, 2017

4 translations issues #1661

Open

[depends] fontconfig 2.12.1

739aa0a

OlegGirko mentioned this pull request Nov 2, 2017

Add missing pieces for PR #1692 #1710

Merged

OlegGirko and others added 7 commits November 2, 2017 04:55

[qa] Switch to py3

08f9c72

Fix interrupted HTTP RPC connection workaround for Python 3.5+

8ae8894

test: Avoid ConnectionResetErrors during RPC tests

c50ed3f

This is necessary on FreeBSD and MacOSX, at least. See bitcoin#8834 (comment)

[travis] Update SDK_URL

a058054

Merge pull request #1710 from OlegGirko/pr-1692

c9c36ca

Add missing pieces for PR #1692

codablock mentioned this pull request Jan 30, 2018

Fix qt and fontconfig depends #1884

Merged

UdjinM6 closed this Jan 31, 2018

UdjinM6 removed this from the 12.3 milestone Jan 31, 2018

UdjinM6 deleted the update_depends branch February 17, 2018 13:17

Uh oh!

Conversation

schinzelh commented Oct 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codablock Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

schinzelh Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

codablock Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

codablock Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

codablock Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

codablock Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

schinzelh commented Oct 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codablock commented Oct 23, 2017

Uh oh!

chaeplin commented Oct 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schinzelh commented Oct 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UdjinM6 commented Dec 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codablock commented Jan 19, 2018

Uh oh!

UdjinM6 commented Jan 29, 2018

Uh oh!

codablock commented Jan 30, 2018

Uh oh!

UdjinM6 commented Jan 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

schinzelh commented Oct 19, 2017 •

edited

Loading

schinzelh commented Oct 23, 2017 •

edited

Loading

chaeplin commented Oct 23, 2017 •

edited

Loading

schinzelh commented Oct 23, 2017 •

edited

Loading

UdjinM6 commented Dec 19, 2017 •

edited

Loading