Backport BIP147 (nulldummy enforcement)#1885
Merged
Merged
Conversation
thephez
reviewed
Feb 13, 2018
|
|
||
| // Deployment of BIP147 | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_BIP147].bit = 2; | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_BIP147].nStartTime = 1519952400; // Feb 30th, 2018 |
Collaborator
There was a problem hiding this comment.
Feb 30th? ;-) Think this comment should be March 2
There was a problem hiding this comment.
Feb 30 is perfectly fine, it's just going to be a veeeeery long winter ☃️
:D
thephez
reviewed
Feb 13, 2018
| // Deployment of BIP147 | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_BIP147].bit = 2; | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_BIP147].nStartTime = 1519952400; // Feb 30th, 2018 | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_BIP147].nTimeout = 1551488400; // Feb 30th, 2019 |
Collaborator
There was a problem hiding this comment.
Ditto here - Feb 30th -> Mar 2nd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports BIP147 from Bitcoin and adds Dash specific BIP9 deployment code.
I was not sure about the parameters for the BIP9 soft fork logic, review and suggestions appreciated.
Bitcoin reused the SegWit soft fork to activate BIP147, so it was easier for them deploy this new enforcement. As we don't have SegWit deployment code, we have to introduce our own deployment.
If anything else comes up before the next release which also requires a soft fork, I'd suggest to rename the deployment to a more generic one and put it into it as well.