Skip to content

Typo in PrivateSend info.#2111

Closed
Duality-CDOO wants to merge 13 commits into
dashpay:developfrom
Duality-CDOO:patch-3
Closed

Typo in PrivateSend info.#2111
Duality-CDOO wants to merge 13 commits into
dashpay:developfrom
Duality-CDOO:patch-3

Conversation

@Duality-CDOO

@Duality-CDOO Duality-CDOO commented Jun 11, 2018

Copy link
Copy Markdown

No description provided.

codablock and others added 13 commits January 5, 2018 16:38
@codablock @UdjinM6
Fix crash on exit when -createwalletbackups=0 (#1810)
ada41c3
@codablock @UdjinM6
Swap iterations and fUseInstantSend parameters in ApproximateBestSubs…
d6e2aa8 
…et (#1819)

#1695 introduced a fix for a instant send related edge case. Somehow the
parameters got mixed up and fUseInstantSend was passed as "iterations".
@laanwj @UdjinM6
Merge bitcoin#8256: BUG: bitcoin-qt crash
068b20b 
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)
@UdjinM6
bump version to 0.12.2.3 (#1827)
63e0e30 
* bump version to 0.12.2.3

* bump version in Doxyfile
@UdjinM6
Vote on IS only if it was accepted to mempool (#1826)
c9bafe1
@UdjinM6
Fix -liquidityprovider option (#1829)
fa5fc41 
revert to pre-1248 logic for liquidity providers
@UdjinM6
Merge pull request #1836 from lodgepole/feature/backport-11847
f71ab1d 
[backport] Fixes compatibility with boost 1.66
@UdjinM6
Skip existing masternode conections on mixing (#1833)
d261575
@UdjinM6
Protect CKeyHolderStorage via mutex (#1834)
21a1005
@UdjinM6
Avoid reference leakage in CKeyHolderStorage::AddKey (#1840)
4768886
@UdjinM6
Merge pull request #1828 from UdjinM6/bp_1810_1819
57e7cc4 
Backport critical fixes from develop
@UdjinM6
Prepare 0.12.2.3 release notes (#1846)
e596762
@Duality-CDOO
Typo in PrivateSend info.
b62d973
@UdjinM6 UdjinM6 added this to the 12.4 milestone Jun 11, 2018
codablock
codablock approved these changes Jun 11, 2018
View reviewed changes

@codablock codablock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nmarley

nmarley commented Jun 11, 2018

Copy link
Copy Markdown

Thanks! Can you rebase this onto develop & update base branch in this PR to develop?

UdjinM6
UdjinM6 requested changes Jun 11, 2018
View reviewed changes

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to what @nmarley said

@UdjinM6 UdjinM6 mentioned this pull request Jun 13, 2018
Merged
@Duality-CDOO

Duality-CDOO commented Jun 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Author

Done ;)

@Duality-CDOO
Duality-CDOO changed the base branch from master to develop June 14, 2018 12:03
@UdjinM6

UdjinM6 commented Jun 14, 2018 •
edited
Loading

Copy link
Copy Markdown

Closing this. The same fix + translations are included in #2120. Thanks for finding the issue :)

PS.
Simply changing branch on github without rebasing doesn't really work in our case, it creates a mess. You need to pull, rebase, push -f and then change the base branch here on github.

@UdjinM6 UdjinM6 closed this Jun 14, 2018
@UdjinM6 UdjinM6 removed this from the 13.0 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 requested changes
+1 more reviewer
@codablock codablock codablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Duality-CDOO @nmarley @UdjinM6 @codablock @laanwj