Do not create mnb until sync is finished#2122
Merged
Merged
Conversation
We don't relay mnb if sync is still in progress. Creating mnb without relaying it only increases inconsistency and leads to user confusion. Unifying conditions for creation and relaying fixes this.
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
We don't relay mnb if sync is still in progress. Creating mnb without relaying it only increases inconsistency and leads to user confusion. Unifying conditions for creation and relaying fixes this.
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 1, 2019
We don't relay mnb if sync is still in progress. Creating mnb without relaying it only increases inconsistency and leads to user confusion. Unifying conditions for creation and relaying fixes this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't relay mnb if sync is still in progress. Creating mnb without relaying it only increases inconsistency and leads to user confusion. Unifying conditions for mnb creation and relaying fixes this.