Change chainlocks enforcing/notification flow - #2762
Conversation
5f8c42b to
cd24474
Compare
|
Rebased. Changes without whitespaces https://github.com/dashpay/dash/pull/2762/files?w=1 |
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Not sure what the opinion is on stuff like this. Again we do it a lot in the code base, but I'm definitely not a fan
|
Hmm, this will conflict quite a bit with what I'm working on right now (what I mentioned on Slack, the rework of how |
Should enforce/notify when we have the block, not when we have only the header or trying to sign the tip (the later won't even work for non-masternodes). Also, fix few related (dead)locks.
|
@codablock I don't see why/how these two would conflict cause this one just fixes it in such a way that it would actually work on all nodes and for both fyi: rebased and force-pushed to trigger Travis build, no code changes. |
|
closing in fav of #2765 |
Should enforce/notify when we have the block, not when we have only the header or trying to sign the tip (the later won't even work for non-masternodes).
Also, fix few related (dead)locks.
NOTE: This includes #2759 atm, will rebase after it's merged. The actual changes are in 081a40c.