Implement retroactive IS locking of transactions first seen in blocks instead of mempool - #2770
Merged
UdjinM6 merged 11 commits intoMar 19, 2019
Merged
Conversation
UdjinM6
reviewed
Mar 14, 2019
UdjinM6
reviewed
Mar 14, 2019
codablock
force-pushed
the
pr_llmq_instantsend_retroactive
branch
from
March 14, 2019 12:53
b397947 to
c6c27f8
Compare
PastaPastaPasta
previously approved these changes
Mar 14, 2019
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
utACK, I don't see anything wrong with it. As long as good testing is done, I am happy :)
Author
|
Please wait with merging, I'd like to do a rebase first after #2774 is merged (I hope this fixes test failures here) |
codablock
force-pushed
the
pr_llmq_instantsend_retroactive
branch
2 times, most recently
from
March 18, 2019 05:03
f8eb94c to
72f0748
Compare
Author
codablock
force-pushed
the
pr_llmq_instantsend_retroactive
branch
from
March 18, 2019 14:05
0d71f7e to
70d939d
Compare
Author
|
Tests are finally green, ready for merge after re-ACK |
|
I'm still not sure if I like the idea tbh 🙈 Also, can we split this PR into two - one for the fixes and the other one for the actual retroactive signing implementation? |
Author
|
Ok, I'll do some PR splitting tomorrow. |
Author
codablock
force-pushed
the
pr_llmq_instantsend_retroactive
branch
from
March 19, 2019 05:24
70d939d to
598d789
Compare
Author
|
I've also rebased this PR on top of #2779 so that the ordering and conflict resolution is already in-place. I also added a commit on top to fix an issue with NewPoWValidBlock |
The UTXO set only works for TXs in the mempool and won't work when we try to retroactively lock unlocked TXs from blocks. This is safe as ProcessTx is only called when a TX was accepted into the mempool or connected in a block, which means that all input checks were good.
… cases SyncTransaction is called from AcceptToMemoryPool and when transactions got connected in a block. So this is the time we want to run TXs through ProcessTx. This also enables retroactive signing of TXs that were unknown before a new block appeared.
NewPoWValidBlock is not guaranteed to be called when blocks come in fast. When a block is accepted in AcceptBlock, NewPoWValidBlock is only called when the new block is a successor of the currently active tip. This is not the case when after the first block a second block is accepted immediately as the first block is not connected yet. This might be a bug actually in the handling of NewPoWValidBlock, so we might need to check/fix this later, but currently I prefer to not touch that part. Instead, we now use SyncTransaction to gather TXs for blockTxs. This works because SyncTransaction is called for all transactions in a freshly connected block in one go. The call also happens before UpdatedBlockTip is called, so it's fine with the existing logic.
codablock
force-pushed
the
pr_llmq_instantsend_retroactive
branch
from
March 19, 2019 08:38
598d789 to
633f64b
Compare
Author
|
Rebased on develop and force-pushed. PR now only contains commits related to the PR. |
UdjinM6
reviewed
Mar 19, 2019
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Looks good 👍
Just a couple small suggestions.
Also check for empty vin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements "retroactive signing" of TXs which were not known before a block appears that contains the TX. This implicitly enables retroactive signing of CLSIGs when included transactions were previously considered "unsafe".
The PR also includes a few fixes for issues I encountered while implementing/testing this.