Skip to content

Some refactoring for spork related functionality in tests#3137

Merged
UdjinM6 merged 4 commits into
dashpay:developfrom
UdjinM6:refsporksintests
Oct 10, 2019
Merged

Some refactoring for spork related functionality in tests#3137
UdjinM6 merged 4 commits into
dashpay:developfrom
UdjinM6:refsporksintests

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented Oct 4, 2019

Copy link
Copy Markdown

Currently based on #3136 (because of wait_to_sync in sporks.py), will rebase.

@UdjinM6 UdjinM6 added this to the 14.1 milestone Oct 4, 2019
@codablock

Copy link
Copy Markdown

LGTM, utACK after rebase

… multikeysporks.py to better match actual functionality

-BEGIN VERIFY SCRIPT-
sed -i 's/_test_spork_state/_test_spork_value/g' test/functional/multikeysporks.py
-END VERIFY SCRIPT-
@UdjinM6

UdjinM6 commented Oct 9, 2019

Copy link
Copy Markdown
Author

Rebased

@nmarley nmarley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock codablock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6
UdjinM6 merged commit dcdf1f3 into dashpay:develop Oct 10, 2019
@UdjinM6
UdjinM6 deleted the refsporksintests branch November 26, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants