Skip to content

Fix updateConfirmations slowness for huge wallets #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UdjinM6 wants to merge 1 commit into from
Closed

Fix updateConfirmations slowness for huge wallets #3154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/qt/transactiontablemodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,12 @@ void TransactionTableModel::updateConfirmations()
{
// Blocks came in since last poll.
// Invalidate status (number of confirmations) and (possibly) description
// for all rows. Qt is smart enough to only actually request the data for the
// visible rows.
Q_EMIT dataChanged(index(0, Status), index(priv->size()-1, Status));
Q_EMIT dataChanged(index(0, ToAddress), index(priv->size()-1, ToAddress));
// for the first 1000 rows. Qt is smart enough to only actually request the data for the
// visible rows, but invalidating data for like 100k+ rows slows things down a lot anyway.
// Invalildating the first 1000 rows should be enough in most cases.
size_t rows = std::min(priv->size(), 1000);
Q_EMIT dataChanged(index(0, Status), index(rows - 1, Status));
Q_EMIT dataChanged(index(0, ToAddress), index(rows - 1, ToAddress));
}

void TransactionTableModel::updateNumISLocks(int numISLocks)
Expand Down