Gradually bump mocktime in wait_for_quorum_connections#3388
Merged
Conversation
UdjinM6
changed the title
Merged
UdjinM6
changed the title
|
Not sure I understand...why is this change necessary? It causes unnecessary wait time when connections need to be re-established. |
|
Is this needed because of such failures? https://gitlab.com/dashpay/dash/-/jobs/490340173 |
Author
|
@codablock yes, this kind of failures. |
|
I'd suggest to also reduce |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 12, 2022
* Gradually bump mocktime in wait_for_quorum_connections * Lower nLLMQConnectionRetryTimeout to 1 sec for regtest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mine_quorummight bump mocktime by 30 seconds a couple of times while waiting for connections which causes test failures sometimes.