qt: Replace usage of QTabBar with custom replacement#3560
Merged
Conversation
This was referenced Jun 26, 2020
xdustinface
force-pushed
the
pr-ui-7-tabbar-replacement
branch
2 times, most recently
from
June 27, 2020 20:22
e4018b7 to
fba4e68
Compare
xdustinface
marked this pull request as draft
June 30, 2020 20:19
This allows to stretch the buttons in the dialog window.
This allows to stretch the buttons in the dialog window.
This allows to stretch the buttons in the dialog window.
xdustinface
force-pushed
the
pr-ui-7-tabbar-replacement
branch
from
July 12, 2020 21:57
fba4e68 to
efbe42a
Compare
Author
|
Ready for review! |
xdustinface
marked this pull request as ready for review
July 12, 2020 21:59
PastaPastaPasta
approved these changes
Jul 14, 2020
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
general utACK... merge conflicts for future backports are really starting to scare me though...
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 1, 2020
* qt: OptionsDialog - Replaced QTabBar with QStackedWidget This allows to stretch the buttons in the dialog window. * qt: RPCConsole - Replaced QTabBar with QStackedWidget This allows to stretch the buttons in the dialog window. * qt: SignVerifyMessageDialog - Replaced QTabBar with QStackedWidget This allows to stretch the buttons in the dialog window. * qt: Add styles for tabbar replacement buttons
christiancfifi
added a commit
to christiancfifi/dash
that referenced
this pull request
Sep 11, 2021
The Dash UI changes were introduced in 83420a1 ("qt: Replace usage of QTabBar with custom replacement (dashpay#3560)", 2020-07-14)
christiancfifi
added a commit
to christiancfifi/dash
that referenced
this pull request
Sep 11, 2021
The Dash UI changes were introduced in 83420a1 ("qt: Replace usage of QTabBar with custom replacement (dashpay#3560)", 2020-07-14)
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 3, 2022
* qt: OptionsDialog - Replaced QTabBar with QStackedWidget This allows to stretch the buttons in the dialog window. * qt: RPCConsole - Replaced QTabBar with QStackedWidget This allows to stretch the buttons in the dialog window. * qt: SignVerifyMessageDialog - Replaced QTabBar with QStackedWidget This allows to stretch the buttons in the dialog window. * qt: Add styles for tabbar replacement buttons
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 9, 2022
The Dash UI changes were introduced in 83420a1 ("qt: Replace usage of QTabBar with custom replacement (dashpay#3560)", 2020-07-14)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3559, its successor is #3561. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.
-> Walk through 0.15
-> Walk through Redesign
I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.
About this PR
This PR removes all occurences of
QTabBar(SignVerifyMessageDialog, OptionsDialog, RPCConsole). Instead it adds aQStackedWidgetas replacement withQPushButtonsin aQHBoxLayoutgrouped into aQButtonGroupabove it to simulate the tabs. This is because theQTabBaritems can't be stretched and styled the way it's possible with theQPushButtons. It also adds stylesheets to give the buttons a nice look.