Skip to content

Prefer creating larger denoms at the second step of CreateDenominated#3589

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
UdjinM6:lessdenoms
Jul 8, 2020
Merged

Prefer creating larger denoms at the second step of CreateDenominated#3589
UdjinM6 merged 1 commit into
dashpay:developfrom
UdjinM6:lessdenoms

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented Jul 6, 2020

Copy link
Copy Markdown

This also means less smaller denoms (which could be good for privacy) and fixes a bug (not mixing all the available funds), see comments in code for more info.

@UdjinM6 UdjinM6 added this to the 16 milestone Jul 6, 2020
PastaPastaPasta
PastaPastaPasta previously approved these changes Jul 6, 2020

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

xdustinface
xdustinface previously approved these changes Jul 7, 2020

@xdustinface xdustinface left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

This also means less smaller denoms (which could be good for privacy) and fixes a bug (not mixing all the available funds), see comments in code for more info.
@UdjinM6

UdjinM6 commented Jul 7, 2020

Copy link
Copy Markdown
Author

Rebased on develop to fix merge conflicts (clean rebase, no actual code changes).

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@xdustinface xdustinface left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6
UdjinM6 merged commit 0891d75 into dashpay:develop Jul 8, 2020
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Aug 23, 2020
…dashpay#3589)

This also means less smaller denoms (which could be good for privacy) and fixes a bug (not mixing all the available funds), see comments in code for more info.
@PastaPastaPasta

Copy link
Copy Markdown
Member

backported in #3670

@UdjinM6
UdjinM6 deleted the lessdenoms branch November 26, 2020 13:27
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 8, 2022
…dashpay#3589)

This also means less smaller denoms (which could be good for privacy) and fixes a bug (not mixing all the available funds), see comments in code for more info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants