test: Implement unit tests for CTransactionBuilder#3677
Merged
Conversation
xdustinface
force-pushed
the
pr-test-transaction-builder
branch
from
September 1, 2020 16:12
778c7e6 to
dde64e3
Compare
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 12, 2020
* makefile.test.include: Let privatesend_tests.cpp depend on ENABLE_WALLET * test: Implement unit tests for CTransactionBuilder * Check that we can decrease the amount and GetAmountLeft() is updated accordingly * Check if resulting tx has a change output when expected * Avoid pushing nullptr into vecOutputs * Add few notes about size calculations * nit: better readability (imo) Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 12, 2022
* makefile.test.include: Let privatesend_tests.cpp depend on ENABLE_WALLET * test: Implement unit tests for CTransactionBuilder * Check that we can decrease the amount and GetAmountLeft() is updated accordingly * Check if resulting tx has a change output when expected * Avoid pushing nullptr into vecOutputs * Add few notes about size calculations * nit: better readability (imo) Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently based on #3657 where the class to test -
CTransactionBuilder- gets introduced.