Implement Block Reward Reallocation#3691
Merged
Merged
Conversation
PastaPastaPasta
requested changes
Sep 8, 2020
Comment on lines
+347
to
+348
| consensus.vDeployments[Consensus::DEPLOYMENT_REALLOC].nStartTime = 1598918400; // Sep 1st, 2020 | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_REALLOC].nTimeout = 1630454400; // Sep 1st, 2021 |
Member
There was a problem hiding this comment.
Change this to October 1st?
Author
There was a problem hiding this comment.
This date doesn't have to be in the future really, just smth close to the release, but ok.
|
|
||
| CAmount masternodeReward = GetMasternodePayment(nBlockHeight, blockReward, nReallocActivationHeight); | ||
|
|
||
| uint256 proTxHash; |
Member
There was a problem hiding this comment.
What's the point of this?
Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
Makes it much more readable imo and avoids calculating the percentage each time.
xdustinface
approved these changes
Sep 10, 2020
xdustinface
left a comment
xdustinface
left a comment
There was a problem hiding this comment.
Looks good, nice tests, they seem to test what they should and they pass, (ut)ACK
PastaPastaPasta
approved these changes
Sep 10, 2020
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
ACK, seems to work as expected. Mainnet syncs
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 12, 2020
* Implement Block Reward Reallocation * Add integr. test * drop unused variable * Sep -> Oct * Update test/functional/feature_block_reward_reallocation.py Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> * Revert to Sep for testnet and devnet * validation: Refactor reallocation calculations Makes it much more readable imo and avoids calculating the percentage each time. * test: Align reallocation calculation with c++ (GetMasternodePayment) * test: Make feature_block_reward_allocation.py executable * Make linter happy Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: xdustinface <xdustinfacex@gmail.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 11, 2022
* Implement Block Reward Reallocation * Add integr. test * drop unused variable * Sep -> Oct * Update test/functional/feature_block_reward_reallocation.py Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> * Revert to Sep for testnet and devnet * validation: Refactor reallocation calculations Makes it much more readable imo and avoids calculating the percentage each time. * test: Align reallocation calculation with c++ (GetMasternodePayment) * test: Make feature_block_reward_allocation.py executable * Make linter happy Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: xdustinface <xdustinfacex@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.