qt: Decouple transaction label updates from transaction status updates#3994
Merged
Conversation
UdjinM6
force-pushed
the
decouple_tx_labels
branch
from
February 11, 2021 18:14
396dbbe to
89e26f8
Compare
UdjinM6
marked this pull request as ready for review
February 11, 2021 18:25
xdustinface
reviewed
Feb 12, 2021
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 12, 2022
dashpay#3994) * qt: Decouple tx label updates from tx status updates * Update src/qt/transactionrecord.cpp Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I doesn't really make much sense to check/update status on address book updates and vice versa.
Based on #3993 atm