Add virtual destructors for CBLSWrapper and CBLSLazyWrapper#4298
Merged
Conversation
Add virtual destructors for CBLSWrapper and CBLSLazyWrapper
UdjinM6
requested changes
Jul 28, 2021
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
PastaPastaPasta
previously approved these changes
Jul 28, 2021
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
utACK for squash merge once CI is happy
PastaPastaPasta
approved these changes
Jul 28, 2021
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
re-utACK for squash merge
UdjinM6
changed the title
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 11, 2022
…4298) * Fixes issue dashpay#3759 Add virtual destructors for CBLSWrapper and CBLSLazyWrapper * Fix linter errors Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add virtual destructors for CBLSWrapper and CBLSLazyWrapper. This prevents from potential memory leaks when derived classes are deleted (using the base pointer)