Skip to content

fix: making builds of guix to produce same output whatever git config#5222

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
knst:guix-fixup-revision
Feb 27, 2023
Merged

fix: making builds of guix to produce same output whatever git config#5222
UdjinM6 merged 1 commit into
dashpay:developfrom
knst:guix-fixup-revision

Conversation

@knst

@knst knst commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

Builds are different, because git command output are different:

Issue being fixed or feature implemented

in pr #5194 different OS produced different hashes of binary.
That's due to different behaviour of this command:

$ git rev-parse --short HEAD
b3f242da14 - on my localhost Kubuntu 22.10
b3f242da1 - inside pastapastapasta's docker

What was done?

This fix forces to git print always 12 character

How Has This Been Tested?

Run in different environment

Breaking Changes

No breaking changes

Checklist:

  • I have performed a self-review of my own code
  • I have assigned this pull request to a milestone

Builds are different, because git command output are different:

$ git rev-parse --short HEAD
b3f242d - on my localhost Kubuntu 22.10
b3f242d - inside pastapastapasta's docker

This fix forces to git print always 12 character
@knst knst added this to the 19 milestone Feb 24, 2023
@knst

knst commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator Author
$ git log --oneline | head -n 1
4c57f4dc72 fix: making builds of guix to produce same output whatever git config
$ sha1sum distsrc-x86_64-linux-gnu/src/dashd
401be366c0fbde3f4b054280558f48d74bfa56d6  distsrc-x86_64-linux-gnu/src/dashd

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

401be366c0fbde3f4b054280558f48d74bfa56d6  distsrc-x86_64-linux-gnu/src/dashd

ACK

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants