Skip to content

fix(ci): skip more jobs in "FAST_MODE"#5311

Merged
PastaPastaPasta merged 1 commit into
dashpay:developfrom
UdjinM6:fix_fast_mode
Apr 14, 2023
Merged

fix(ci): skip more jobs in "FAST_MODE"#5311
PastaPastaPasta merged 1 commit into
dashpay:developfrom
UdjinM6:fix_fast_mode

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented Apr 10, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

CI should not be running that many jobs in "FAST_MODE"
https://github.com/dashpay/dash/blob/develop/.gitlab-ci.yml#L5

What was done?

assign .skip-in-fast-mode-template template to more jobs

How Has This Been Tested?

ran CI in my repo
before: https://gitlab.com/UdjinM6/dash/-/pipelines/832175740
after: https://gitlab.com/UdjinM6/dash/-/pipelines/832176325

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@UdjinM6 UdjinM6 added this to the 20 milestone Apr 10, 2023
Comment thread .gitlab-ci.yml
extends: .build-template
extends:
- .build-template
- .skip-in-fast-mode-template

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fuzz build is important for fast mode because usually it catches high percentage of all failures.

There is almost hundred of C++ source and any changes in class/structure interfaces, any noticeable big refactoring or big changes almost always cause a fail during fuzz build.

I vote for keeping linux64_fuzz-build in fast-mode

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... but we don't really run src/test/fuzz/fuzz anywhere as far as I can tell, we just compile it

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UdjinM6
UdjinM6 requested a review from knst April 12, 2023 23:02
@UdjinM6
UdjinM6 requested a review from PastaPastaPasta April 12, 2023 23:02

@knst knst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't often use fast-mode, so, utACK

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta
PastaPastaPasta merged commit f4eaf5a into dashpay:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants