fix(ci): skip more jobs in "FAST_MODE"#5311
Conversation
| extends: .build-template | ||
| extends: | ||
| - .build-template | ||
| - .skip-in-fast-mode-template |
There was a problem hiding this comment.
I think fuzz build is important for fast mode because usually it catches high percentage of all failures.
There is almost hundred of C++ source and any changes in class/structure interfaces, any noticeable big refactoring or big changes almost always cause a fail during fuzz build.
I vote for keeping linux64_fuzz-build in fast-mode
There was a problem hiding this comment.
hmmm... but we don't really run src/test/fuzz/fuzz anywhere as far as I can tell, we just compile it
There was a problem hiding this comment.
just on this week PRs that failed for fuzz related code (compile, not run!):
- backport: trivial backports 2023 04 09 #5310 - https://gitlab.com/dashpay/dash/-/jobs/4087550129
- backport: merge bitcoin#19192, #18968, #19191, #18991, #19658, #19697, #20000, #19638, #20120, #20757, #20965, #20284, #22025, #22179 (auxiliary backports: part 10) #5306 - https://gitlab.com/dashpay/dash/-/pipelines/832877324
knst
left a comment
There was a problem hiding this comment.
I don't often use fast-mode, so, utACK
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Issue being fixed or feature implemented
CI should not be running that many jobs in "FAST_MODE"
https://github.com/dashpay/dash/blob/develop/.gitlab-ci.yml#L5
What was done?
assign
.skip-in-fast-mode-templatetemplate to more jobsHow Has This Been Tested?
ran CI in my repo
before: https://gitlab.com/UdjinM6/dash/-/pipelines/832175740
after: https://gitlab.com/UdjinM6/dash/-/pipelines/832176325
Breaking Changes
n/a
Checklist:
For repository code-owners and collaborators only