Skip to content

backport: merge bitcoin#18574, #18653, #18691, #18724, #18594, #19991, #19133, #19643, #20002, #19354, partial #19998 (cli backports)#5329

Merged
PastaPastaPasta merged 11 commits into
dashpay:developfrom
kwvg:dashcli_bps
Apr 17, 2023

Conversation

@kwvg

@kwvg kwvg commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@kwvg
kwvg force-pushed the dashcli_bps branch 3 times, most recently from 57b365c to 5742ee1 Compare April 16, 2023 09:32
@kwvg
kwvg marked this pull request as ready for review April 16, 2023 11:20
@kwvg kwvg changed the title backport: bitcoin#18574, #19991, #19643, #20002, partial #18594, #19133, #19998 (cli backports) backport: merge bitcoin#18574, #18653, #18691, #18724, #18594, #19991, #19133, #19643, #20002, partial #19998 (cli backports) Apr 16, 2023

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@knst knst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but see a comment about dashification

Comment thread src/bitcoin-cli.cpp Outdated
Comment thread test/functional/interface_bitcoin_cli.py
Comment thread test/functional/interface_bitcoin_cli.py Outdated
Comment thread src/bitcoin-cli.cpp Outdated
Comment thread doc/tor.md Outdated
Comment thread src/bitcoin-cli.cpp Outdated
Comment thread src/bitcoin-cli.cpp
@kwvg
kwvg requested review from UdjinM6 and knst April 17, 2023 08:41

@knst knst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kwvg kwvg changed the title backport: merge bitcoin#18574, #18653, #18691, #18724, #18594, #19991, #19133, #19643, #20002, partial #19998 (cli backports) backport: merge bitcoin#18574, #18653, #18691, #18724, #18594, #19991, #19133, #19643, #20002, #19354, partial #19998 (cli backports) Apr 17, 2023
@UdjinM6 UdjinM6 added this to the 20 milestone Apr 17, 2023

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta
PastaPastaPasta merged commit 37a4a30 into dashpay:develop Apr 17, 2023
@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants