Skip to content

revert: 5636, introduce -llmqtestinstantsend and -llmqtestinstantsenddip0024 - #5654

Merged
PastaPastaPasta merged 2 commits into
dashpay:developfrom
UdjinM6:revert_5636
Oct 30, 2023
Merged

revert: 5636, introduce -llmqtestinstantsend and -llmqtestinstantsenddip0024#5654
PastaPastaPasta merged 2 commits into
dashpay:developfrom
UdjinM6:revert_5636

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented Oct 29, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

This reverts #5636 and introduces 2 similar cmd-line/config params which are made specifically for regtest. Turned out Platform guys actually still need smth like that for local testing #5259.

What was done?

pls see individual commits

How Has This Been Tested?

run tests but we don't really have(/need?) tests for this.

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

cc @shumkov

@UdjinM6 UdjinM6 added this to the 20 milestone Oct 29, 2023

@ogabrielides ogabrielides left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ogabrielides ogabrielides changed the title fix: Revert 5636, introduce -llmqtestinstantsend and -llmqtestinstantsenddip0024 revert: 5636, introduce -llmqtestinstantsend and -llmqtestinstantsenddip0024 Oct 30, 2023
@QuantumExplorer

Copy link
Copy Markdown
Member

utACK

@knst knst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta
PastaPastaPasta merged commit d8db2e9 into dashpay:develop Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants