Skip to content

test: fix feature_governance.py - #5657

Merged
PastaPastaPasta merged 1 commit into
dashpay:developfrom
UdjinM6:fix_gov_test
Oct 31, 2023
Merged

test: fix feature_governance.py#5657
PastaPastaPasta merged 1 commit into
dashpay:developfrom
UdjinM6:fix_gov_test

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented Oct 30, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

test/functional/feature_governance.py:205:59: F821 undefined name 'p0_amount'
test/functional/feature_governance.py:205:95: F821 undefined name 'p1_amount'
test/functional/feature_governance.py:205:131: F821 undefined name 'p2_amount'

What was done?

add missing self.

How Has This Been Tested?

run linter and feature_governance.py

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20 milestone Oct 30, 2023

@knst knst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

Without changes:

2023-10-30T18:02:05.954000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/home/knst/projects/dash/test/functional/test_framework/test_framework.py", line 155, in main
    self.run_test()
  File "/home/knst/projects/dash/test/functional/feature_governance.py", line 205, in run_test
    payment_amounts_expected = [str(satoshi_round(str(p0_amount))), str(satoshi_round(str(p1_amount))), str(satoshi_round(str(p2_amount)))]
                                                      ^^^^^^^^^
NameError: name 'p0_amount' is not defined

with changes:

2023-10-30T18:08:37.257000Z TestFramework (INFO): Tests successful

@ogabrielides ogabrielides left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta
PastaPastaPasta merged commit 25ee167 into dashpay:develop Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants