Skip to content

refactor: move HD code from CWallet to LegacyScriptPubKeyMan#5854

Merged
PastaPastaPasta merged 15 commits into
dashpay:developfrom
knst:hd-1
Mar 5, 2024
Merged

refactor: move HD code from CWallet to LegacyScriptPubKeyMan#5854
PastaPastaPasta merged 15 commits into
dashpay:developfrom
knst:hd-1

Conversation

@knst

@knst knst commented Jan 31, 2024

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

During backport bitcoin#17261 significant part of HD chain has been forgotten in CWallet due to our own implementation.

This PR do not change behaviour of HD wallets, it's just refactoring.

What was done?

This PR refactor HD wallets implementation:

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 20.1 milestone Jan 31, 2024
@knst knst mentioned this pull request Jan 31, 2024
5 tasks
@PastaPastaPasta
PastaPastaPasta marked this pull request as draft February 5, 2024 16:12
@github-actions

github-actions Bot commented Feb 9, 2024

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@knst
knst marked this pull request as ready for review February 12, 2024 15:41

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Will test it a bit

Comment thread src/wallet/scriptpubkeyman.cpp Outdated
UdjinM6
UdjinM6 previously approved these changes Feb 13, 2024

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

light ACK

UdjinM6
UdjinM6 previously approved these changes Feb 14, 2024

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@github-actions

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@UdjinM6 UdjinM6 modified the milestones: 20.1, 21 Mar 5, 2024
@knst

knst commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator Author

@knst knst force-pushed the hd-1 branch from d0f309f to b5f4411

rebased to be on top of post-merged master to develop

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants