docs: add release notes for 20.1.0 by PastaPastaPasta · Pull Request #5910 · dashpay/dash

PastaPastaPasta · 2024-02-28T23:21:51Z

Issue being fixed or feature implemented

Added release notes for 20.1.0

What was done?

Wrote release notes from WIP release-notes; trimmed some fat from release notes

How Has This Been Tested?

Ran linters

Breaking Changes

None; docs only

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

knst · 2024-02-29T13:58:37Z

+- `fundrawtransaction` and `walletcreatefundedpsbt` when used with the `lockUnspents` argument now lock manually
+selected coins, in addition to automatically selected coins. Note that locked coins are never used in automatic coin
+selection, but can still be manually selected.
+- The `testmempoolaccept` RPC returns `vsize` and a `fee` object with the `base` fee if the transaction passes


should we rename vsize to size due to no SegWit? if it will be renamed now before release - no breaking changes. Rename it later - it would be a breaking changes.

knst · 2024-02-29T14:14:54Z

+support and will be removed in future releases. Importantly, even with an HD wallet, users can still import non-HD
+private keys, ensuring flexibility in managing their funds.
+
+## Configuration option changes


Suggested change

## Configuration option changes

## Windows release

Windows release is signed by a new certificate to replace old expired one.

thephez

Some suggestions

knst

LGTM

kwvg

LGTM

UdjinM6 · 2024-02-29T20:03:28Z

I think we should also mention complete removal of legacy IS support (no -llmqinstantsend and -llmqtestinstantsend cmd-line options, no islock msg, no inv 30) #5553 and protocol bump to 70231 #5905

PastaPastaPasta · 2024-03-01T16:18:32Z

I think we should also mention complete removal of legacy IS support (no -llmqinstantsend and -llmqtestinstantsend cmd-line options, no islock msg, no inv 30) #5553 and protocol bump to 70231 #5905

Would you like to propose some language around this?

UdjinM6 · 2024-03-01T18:46:02Z

I think we should also mention complete removal of legacy IS support (no -llmqinstantsend and -llmqtestinstantsend cmd-line options, no islock msg, no inv 30) #5553 and protocol bump to 70231 #5905

Would you like to propose some language around this?

I think smth like:

Legacy InstantSend was deprecated with the activation of Deterministic InstantSend but we kept the underlying logic for some time to ensure smooth transition. v20.1 finally removes all of Legacy InstantSend logic and will no longer support sending and receiving islock p2p message and inv p2p message with id equal 30. Such messages will be seen as unknown by v20.1 nodes. To make it clear that there was a change in network protocol the version was bumped to 70231. Please note that -llmqinstantsend and -llmqtestinstantsend command line options are no longer available either.

I'd like to also ask @thephez to rephrase it to sound a bit better though :)

thephez · 2024-03-02T14:36:00Z

Legacy InstantSend was deprecated with the activation of Deterministic InstantSend but we kept the underlying logic for some time to ensure smooth transition. v20.1 finally removes all of Legacy InstantSend logic and will no longer support sending and receiving islock p2p message and inv p2p message with id equal 30. Such messages will be seen as unknown by v20.1 nodes. To make it clear that there was a change in network protocol the version was bumped to 70231. Please note that -llmqinstantsend and -llmqtestinstantsend command line options are no longer available either.

Looks good. I just made a couple small changes...

Legacy InstantSend was deprecated with the activation of Deterministic InstantSend but we kept the underlying logic for some time to ensure a smooth transition. v20.1 finally removes all Legacy InstantSend logic and will no longer support sending and receiving islock p2p message and inv p2p message with id equal 30. Such messages will be seen as unknown by v20.1 nodes. The protocol version was incremented to 70231 to indicate a change in network protocol. Please note that the -llmqinstantsend and -llmqtestinstantsend command line options have also been removed as part of this change.

knst

LGTM

UdjinM6

utACK

thephez

The deterministic IS section is at the wrong heading level. Also, fixed a couple typos in that section.

UdjinM6

re-utACK

thephez

utACK

Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: Konstantin Akimov <knstqq@gmail.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

7f57516 docs: add v20.0.4 release notes (pasta) Pull request description: ## Issue being fixed or feature implemented We didn't archive v20.0.4 release notes somehow in #5910 ## What was done? Archive 20.0.4 release notes ## How Has This Been Tested? ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: d703dedf1aad2afb5eb8af291f89e38fa2dfb4185ef9e25194c273bb9f04ae8075ea87318552b468b1a487b39b95cf1dee794d3d3c5b8a863dbfd6d458ee8e72

7f57516 docs: add v20.0.4 release notes (pasta) Pull request description: ## Issue being fixed or feature implemented We didn't archive v20.0.4 release notes somehow in dashpay#5910 ## What was done? Archive 20.0.4 release notes ## How Has This Been Tested? ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: d703dedf1aad2afb5eb8af291f89e38fa2dfb4185ef9e25194c273bb9f04ae8075ea87318552b468b1a487b39b95cf1dee794d3d3c5b8a863dbfd6d458ee8e72

PastaPastaPasta added this to the 20.1 milestone Feb 28, 2024

PastaPastaPasta requested a review from thephez February 28, 2024 23:21

UdjinM6 requested changes Feb 29, 2024

View reviewed changes

Comment thread doc/release-notes.md Outdated

Comment thread doc/release-notes.md Outdated

Comment thread doc/release-notes.md

Comment thread doc/release-notes.md Outdated

knst requested changes Feb 29, 2024

View reviewed changes

thephez reviewed Feb 29, 2024

View reviewed changes

Comment thread doc/release-notes.md Outdated

Comment thread doc/release-notes.md Outdated

Comment thread doc/release-notes.md Outdated

Comment thread doc/release-notes.md Outdated

thephez reviewed Feb 29, 2024

View reviewed changes

Comment thread doc/release-notes.md Outdated

Comment thread doc/release-notes.md Outdated

PastaPastaPasta commented Feb 29, 2024

View reviewed changes

Comment thread doc/release-notes.md Outdated

PastaPastaPasta requested review from UdjinM6, knst and thephez February 29, 2024 17:13

thephez reviewed Feb 29, 2024

View reviewed changes

Comment thread doc/release-notes.md Outdated

Comment thread doc/release-notes.md Outdated

Comment thread doc/release-notes.md Outdated

knst previously approved these changes Feb 29, 2024

View reviewed changes

kwvg approved these changes Feb 29, 2024

View reviewed changes

thephez reviewed Feb 29, 2024

View reviewed changes

Comment thread doc/release-notes.md Outdated

PastaPastaPasta dismissed knst’s stale review via a9507d2 March 1, 2024 16:18

PastaPastaPasta commented Mar 3, 2024

View reviewed changes

Comment thread doc/release-notes.md Outdated

PastaPastaPasta requested review from knst and thephez March 3, 2024 16:37

knst previously approved these changes Mar 3, 2024

View reviewed changes

UdjinM6 previously approved these changes Mar 4, 2024

View reviewed changes

thephez reviewed Mar 4, 2024

View reviewed changes

Comment thread doc/release-notes.md Outdated

UdjinM6 mentioned this pull request Mar 4, 2024

backport: bitcoin#18937, #19390, #19473, #19478, #19489, #19596, #19657, #19727, #19816, partial #18638 #5919

Merged

5 tasks

PastaPastaPasta dismissed stale reviews from UdjinM6 and knst via 2ddfce5 March 4, 2024 14:53

PastaPastaPasta requested review from UdjinM6 and thephez March 4, 2024 14:54

PastaPastaPasta requested a review from knst March 4, 2024 14:54

UdjinM6 approved these changes Mar 4, 2024

View reviewed changes

thephez approved these changes Mar 4, 2024

View reviewed changes

PastaPastaPasta force-pushed the 20.1.0-release-notes branch from 2ddfce5 to 717257c Compare March 4, 2024 15:12

docs: add release notes for 20.1.0

a4edab6

Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: Konstantin Akimov <knstqq@gmail.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

PastaPastaPasta force-pushed the 20.1.0-release-notes branch from 717257c to a4edab6 Compare March 4, 2024 21:15

PastaPastaPasta closed this pull request by merging all changes into dashpay:develop in 032c8fa Mar 4, 2024

PastaPastaPasta mentioned this pull request Apr 3, 2024

docs: add v20.0.4 release notes #5968

Merged

5 tasks

	## Configuration option changes
	## Windows release
	Windows release is signed by a new certificate to replace old expired one.

Uh oh!

Conversation

PastaPastaPasta commented Feb 28, 2024

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

knst Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

knst Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

knst left a comment

Choose a reason for hiding this comment

Uh oh!

kwvg left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Feb 29, 2024

Uh oh!

Uh oh!

PastaPastaPasta commented Mar 1, 2024

Uh oh!

UdjinM6 commented Mar 1, 2024

Uh oh!

thephez commented Mar 2, 2024

Uh oh!

Uh oh!

knst left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants