backport: bitcoin#23723, 23547, 24153, 23591#6274
Merged
Merged
Conversation
…isminefilter fa2c991 refactor: Use underlying type of isminetype for isminefilter (MarcoFalke) Pull request description: This does not change behavior, but it would be good for code clarity and to avoid `-Wimplicit-int-conversion` compiler warnings to use the an int of the same width for both `isminetype` and `isminefilter`. ACKs for top commit: laanwj: Code review ACK fa2c991 shaavan: crACK fa2c991 promag: Code review ACK fa2c991. Tree-SHA512: b3e255de7c9b1dea272bc8cb9386b339fe701f18580e03e997c270cac6453088ca2032e26e39f536d66cd1b6fda3e96bdbdc6e960879030e635338d0916277e6
fa3bdbd test: remove unused sanitizer suppressions (MarcoFalke) Pull request description: Looks like those are not needed (anymore) ACKs for top commit: fanquake: ACK fa3bdbd Tree-SHA512: 4bedb6363aba8ea7763291ee0cd074e6bfd77e691bb32999c3959393864dc396bacba1eced2b10d9d600b66e8b83b91f7bc6692331dbd113bbaa87e72d11e2e8
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_100_1_Part_1
branch
from
September 14, 2024 15:10
5b1f515 to
829e192
Compare
vijaydasmp
changed the title
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_100_1_Part_1
branch
from
September 14, 2024 16:32
829e192 to
6427aa4
Compare
vijaydasmp
marked this pull request as ready for review
September 14, 2024 17:54
Author
|
Hello @UdjinM6, requesting review |
|
re 23002 "Make descriptor wallets by default": Do we have everything prepared for this @knst? |
Collaborator
Basically, everything is ready https://github.com/dashpay/dash-issues/issues/59 except mnemonics for descriptor wallets, which is quite important IMO. But, we should not merge 23002 yet, because that's a breaking changes, at least not before v22 is branched-out. Also, there's couple useful follow-ups must be done:
@vijaydasmp could you exclude 23002 from this PR, please? |
Author
|
Sure
…On Tue, 17 Sept, 2024, 13:51 Konstantin Akimov, ***@***.***> wrote:
re 23002 "Make descriptor wallets by default": Do we have everything
prepared for this @knst <https://github.com/knst>?
Basically, everything is ready dashpay/dash-issues#59
<https://github.com/dashpay/dash-issues/issues/59> except mnemonics for
descriptor wallets, which is quite important IMO.
*But, we should not merge 23002 yet, because that's a breaking changes, at
least not before v22 is branched-out.*
Also, there's couple useful follow-ups must be done:
- remove "experimental" hint from Qt's interface
- remove the extra requirement for load_on_startup flagfrom
createwallet rpc, which has been introduced due to RPCinterface
changes (see #6095 <#6095>)
@vijaydasmp <https://github.com/vijaydasmp> could you exclude 23002 from
this PR, please?
—
Reply to this email directly, view it on GitHub
<#6274 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5IIRCUP2XMIMTVOKL42LZW7Q73AVCNFSM6AAAAABOG5MFVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJUHA3DAMBZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
added 2 commits
September 21, 2024 18:32
…rtfee if smart fee data is unavailable cd8d156 Bugfix: RPC/mining: Fail properly in estimatesmartfee if smart fee data is unavailable (Luke Dashjr) Pull request description: Fixes a regression introduced by bitcoin#22722 (Not entirely sure on the solution) ACKs for top commit: prayank23: crACK bitcoin@cd8d156 darosior: utACK cd8d156 kristapsk: utACK cd8d156 Tree-SHA512: eb4aa3cc345c69c44ffd5733b51b90eefe1d7854b7a2855e8cbb98268db24d43b7d0ae9fbb0eccf9b6dc01da644d19433cc77fec52ff67bf890be1fc53a67fc4
fa1b63c test: Replace hashlib.new with named constructor (MarcoFalke) Pull request description: A small refactor that doesn't matter too much, but it using the named constructor is nice because: * It clarifies that it is a built-in function * It is (trivially) faster and less code. ACKs for top commit: Zero-1729: ACK fa1b63c w0xlt: ACK fa1b63c Tree-SHA512: d23dc4552c1e6fc1f90f8272e47e4efcbe727f0b66a6f6a264db8a50ee6cb6d57a2809befcb95fda6725136672268633817a03dd1859f2298d20e3f9e0ca4a7f
vijaydasmp
force-pushed
the
bp23_100_1_Part_1
branch
from
September 21, 2024 13:03
6427aa4 to
073d6d6
Compare
Author
UdjinM6
approved these changes
Sep 21, 2024
UdjinM6
changed the title
knst
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport brings the following chnages,
estimatesmartfeeRPC command.