test: extend and refactor DIP0020 activation test#6298
Merged
Conversation
Collaborator
|
It adds test, but doesn't fix crash, right? |
UdjinM6
marked this pull request as draft
October 1, 2024 16:07
Author
|
Indeed, a fix for the crash would be smth like #6299 |
UdjinM6
marked this pull request as ready for review
October 1, 2024 19:15
5 tasks
knst
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
23590 backport in #6256 results in node crashes (for dashd compiled withthere is only rpc part and no tests for relaying such txes via p2p.--enable-debug) when we try to spend coins locked via disabled opcodes infeature_dip0020_activation.py. Also,What was done?
How Has This Been Tested?
run test on develop and on top of #6256 + #6299 with and without
--enable-debugBreaking Changes
Checklist: