feat: remove DIP0020 requirement for OP_ since it is activated long time ago#6302
Merged
PastaPastaPasta merged 3 commits intoOct 15, 2024
Merged
Conversation
5 tasks
|
I'm really surprised it's possible to just drop a flag like that.... will need to think/test a bit... |
UdjinM6
reviewed
Oct 4, 2024
|
Couldn't think of any issues, seems to be a valid solution 👍 just one small suggestion, see above |
|
This pull request has conflicts, please rebase. |
knst
force-pushed
the
refactor-dip-0020-simplify
branch
from
October 4, 2024 19:26
bc8678f to
3fe6d14
Compare
UdjinM6
previously approved these changes
Oct 4, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
light ACK 3fe6d145be9a453f80ab16acf567d629ec744744
Collaborator
Author
|
CI failure after rebase is unrelated, see #6315 |
|
This pull request has conflicts, please rebase. |
knst
force-pushed
the
refactor-dip-0020-simplify
branch
from
October 8, 2024 08:26
3fe6d14 to
c8fd37d
Compare
UdjinM6
approved these changes
Oct 8, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
it's alternate solution for #6299 to fix a crash reported #6256
What was done?
Removed code related to DIP0020 activation for various OP codes. DIP0020 is activated long time ago and no any historical blocks are violating rules, removing it's backwards compatible.
How Has This Been Tested?
Run unit and functional tests. See also changes in data for unit tests and removed functional test.
It also re-index mainnet and testnet successfully
Also extra test is done with bitcoin#23590 - no crash with it in
feature_dip0020_activation.py[modified assuming it is always activated]Breaking Changes
N/A
Checklist: