fix(qt): handle pixel-sized fonts when scaling widgets by thepastaclaw · Pull Request #7315 · dashpay/dash

thepastaclaw · 2026-05-09T07:42:50Z

Pixel-sized font scaling fix

Summary

handle Qt widgets whose stylesheet fonts are pixel-sized when
GUIUtil::updateFonts() runs
convert pixel sizes to point-size equivalents before applying the existing
font-scaling path
avoid the macOS assertion abort seen while opening the recovery phrase dialog

Fixes #7281.

Validation

git diff --check upstream/develop...HEAD
code-review gate: ship for upstream/develop..tracker-1251
Static validation only. I do not have a macOS Tahoe GUI environment available
to reproduce the original crash locally.

github-actions · 2026-05-09T07:43:27Z

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

thepastaclaw · 2026-05-09T07:44:06Z

@coderabbitai review

coderabbitai · 2026-05-09T07:44:11Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

thepastaclaw · 2026-05-09T07:45:04Z

✅ Review complete (commit 9c94795)

coderabbitai · 2026-05-09T07:47:29Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cee2f4de-fc71-4e78-af7b-7c0c27f974f3

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd84aa and 9c94795.

📒 Files selected for processing (1)

src/qt/guiutil_font.cpp

Walkthrough

This change improves the robustness of font size detection in GUIUtil::updateFonts() within the Qt GUI utility layer. The function now computes baseline font sizes using QFont::pointSizeF() as the primary source and, when that yields a non-positive value but pixel size is available, derives the point size from pixelSize * 72 / logicalDpiY(). Widgets with resulting non-positive sizes are skipped rather than triggering an assertion. The default font size stored in the mapping is now the computed double value instead of the int result from pointSize().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: handling pixel-sized fonts in Qt widget scaling.
Description check	✅ Passed	The description is directly related to the changeset, explaining the problem, solution, and validation approach.
Linked Issues check	✅ Passed	The changes address the root cause of issue `#7281` by fixing font scaling logic to handle pixel-sized fonts, preventing the macOS crash.
Out of Scope Changes check	✅ Passed	All changes in src/qt/guiutil_font.cpp are directly related to the linked issue's objective of fixing GUI font handling.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

thepastaclaw

Code Review

Small, focused Qt fix replacing a fatal assert with a graceful pixel-to-point conversion path for stylesheet-driven pixel-sized fonts. Logic is sound; idempotency via mapWidgetDefaultFontSizes::emplace is preserved. No blocking issues — only two low-impact nitpicks worth surfacing.

Reviewed commit: 9c94795

💬 2 nitpick(s)

thepastaclaw · 2026-05-09T20:46:54Z

+        if (font_size <= 0 && font.pixelSize() > 0) {
+            font_size = font.pixelSize() * 72.0 / w->logicalDpiY();
+            font.setPointSizeF(font_size);
+        }


💬 Nitpick: setPointSizeF on line 585 is redundant

The local font is either fully replaced by getFont(...) on line 604 (when an entry exists in mapFontUpdates) or has its size overwritten by setPointSizeF(GetScaledFontSize(...)) on line 606. The explicit font.setPointSizeF(font_size) on line 585 has no observable effect on the font ultimately stored in mapWidgetFonts or compared at line 609. Removing it would tighten the code; keeping it is harmless as a defensive normalization.

_{source: ['claude']}

thepastaclaw · 2026-05-09T20:46:55Z

+        if (font_size <= 0 && font.pixelSize() > 0) {
+            font_size = font.pixelSize() * 72.0 / w->logicalDpiY();
+            font.setPointSizeF(font_size);
+        }
+        if (font_size <= 0) {
+            continue;
+        }


💬 Nitpick: logicalDpiY() result is cached for the lifetime of the widget

w->logicalDpiY() correctly reports the DPI of the widget's current screen, but the derived point-size is then cached in mapWidgetDefaultFontSizes as the widget's 'default font size'. If the widget later migrates to a screen with a different DPI, the cached value will no longer correspond to the original pixel size. The same caching limitation exists in the pre-PR code paths, so this is not a regression — just a corner case worth noting.

_{source: ['claude']}

thepastaclaw · 2026-05-19T15:07:19Z

Closing during authored-PR cleanup. This small Qt font-scaling draft is not currently review-priority; can be reopened/recreated if the underlying issue becomes active.

67d25da test: require fonts for pixel-sized widget regression (PastaClaw) 469abf8 test: cover pixel-sized font conversion (PastaClaw) 443e1d3 qt: convert pixel font sizes in class and QTextEdit paths (PastaClaw) 322f257 qt: fix abort in updateFonts() with pixel-sized fonts (PastaClaw) b6dd65a qt: add effectivePointSize() helper for pixel-sized fonts (PastaClaw) Pull request description: # Pixel-sized font scaling fix ## Issue being fixed or feature implemented `GUIUtil::updateFonts()` assumed every widget font had a positive point size. The recovery-phrase dialog stylesheet uses pixel-sized fonts, for which Qt reports an invalid point size, so an asynchronous global font refresh could abort while the dialog was open. This caused the original macOS report in #7281 and the cross-platform recurrence in #7464. Fixes #7281. Fixes #7464. Supersedes the earlier closed draft #7315, which GitHub would not reopen after the branch was rebased onto current `develop`. ## What was done? - Add a shared helper that preserves valid point sizes and converts valid pixel sizes using the relevant logical DPI. - Use the helper in the widget sweep, class-level font map, and `QTextEdit` styling path. - Skip individual widgets when Qt provides neither a valid point size nor a safely convertible pixel size. - Preserve fractional point sizes and the existing non-compounding per-widget cache behavior. - Add deterministic helper coverage and a focused `GUIUtil::updateFonts()` regression test to the existing `OptionTests` suite without changing test order or adding a translation unit. ## How Has This Been Tested? - A full local build completes successfully. - `QT_QPA_PLATFORM=minimal ./src/qt/test/test_dash-qt updateFontsWithPixelSizedWidget` passes with 7 `OptionTests` passing and the integration body explicitly skipped because the `minimal` plugin cannot load application fonts. The deterministic `effectivePointSize()` coverage runs under this configuration. - On a GUI-capable platform where `AppTests` successfully loads application fonts, `updateFontsWithPixelSizedWidget()` hard-checks that initialization occurred before exercising the production sweep and repeated-update cache behavior. - `git diff --check upstream/develop...HEAD`, lint, and clang-format checks pass. ## Breaking Changes None. ## Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation, where applicable - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes Top commit has no ACKs. Tree-SHA512: d928c92d4987c999324d87907670f23b4cac0569f45230da2e6a11de4e043a14a3a734334806a80e1921b8e1b067e1409018f4e74b375728568ad6c045c6958e

qt: handle pixel-sized fonts when scaling widgets

9c94795

thepastaclaw commented May 9, 2026

View reviewed changes

thepastaclaw closed this May 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(qt): handle pixel-sized fonts when scaling widgets - #7315

fix(qt): handle pixel-sized fonts when scaling widgets#7315
thepastaclaw wants to merge 1 commit into
dashpay:developfrom
thepastaclaw:tracker-1251

thepastaclaw commented May 9, 2026

Uh oh!

github-actions Bot commented May 9, 2026

Uh oh!

thepastaclaw commented May 9, 2026

Uh oh!

coderabbitai Bot commented May 9, 2026

Uh oh!

thepastaclaw commented May 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 9, 2026

❌ Failed checks (1 warning)

Uh oh!

thepastaclaw left a comment

Uh oh!

thepastaclaw May 9, 2026

Uh oh!

thepastaclaw May 9, 2026

Uh oh!

thepastaclaw commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

thepastaclaw commented May 9, 2026

Pixel-sized font scaling fix

Summary

Validation

Uh oh!

github-actions Bot commented May 9, 2026

✅ No Merge Conflicts Detected

Uh oh!

thepastaclaw commented May 9, 2026

Uh oh!

coderabbitai Bot commented May 9, 2026

Uh oh!

thepastaclaw commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 9, 2026

Walkthrough

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

thepastaclaw left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

thepastaclaw May 9, 2026

Choose a reason for hiding this comment

Uh oh!

thepastaclaw May 9, 2026

Choose a reason for hiding this comment

Uh oh!

thepastaclaw commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

thepastaclaw commented May 9, 2026 •

edited

Loading