fix: drop virtual specifier for CZMQNotificationInterface dtor

[UdjinM6]

Issue being fixed or feature implemented

In file included from zmq/zmqnotificationinterface.cpp:5:
./zmq/zmqnotificationinterface.h:22:13: error: virtual method '~CZMQNotificationInterface' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
   22 |     virtual ~CZMQNotificationInterface();
      |             ^
1 error generated.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[thepastaclaw]

✅ Review complete (commit 8714052)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a56b8f40-e137-40be-bdea-b2eeabd1595f

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd84aa and 8714052.

📒 Files selected for processing (1)

• src/zmq/zmqnotificationinterface.h

---

Walkthrough

The virtual keyword is removed from the destructor declaration of the CZMQNotificationInterface class in the header file. The destructor signature changes from virtual ~CZMQNotificationInterface(); to ~CZMQNotificationInterface();. This is a single-line modification affecting only the public interface declaration of the class.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: removing the virtual specifier from the CZMQNotificationInterface destructor to fix a compiler error in a final class.
Description check	✅ Passed	The description is directly related to the changeset, clearly explaining the compilation error that triggered the fix and what was changed to resolve it.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thepastaclaw]

Code Review

Trivial single-line warning fix removing redundant virtual from ~CZMQNotificationInterface() since the class is final. Verified the patch matches the worktree at 8714052: the change is limited to src/zmq/zmqnotificationinterface.h and is correct — CValidationInterface has a protected non-virtual defaulted destructor, so polymorphic deletion through the base is not intended. Both agents reported no findings; concurring with clean approval.

Reviewed commit: 8714052

[knst]

utACK 8714052