Skip to content

test: fix funding for ProRegTx with external collateral#7467

Open
UdjinM6 wants to merge 1 commit into
dashpay:developfrom
UdjinM6:fu_7455
Open

test: fix funding for ProRegTx with external collateral#7467
UdjinM6 wants to merge 1 commit into
dashpay:developfrom
UdjinM6:fu_7455

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented Jul 15, 2026

Copy link
Copy Markdown

Issue being fixed or feature implemented

#7455 follow-up

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 24 milestone Jul 15, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@thepastaclaw

thepastaclaw commented Jul 15, 2026

Copy link
Copy Markdown

🔍 Review in progress — actively reviewing now (commit 2144bf2)

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 621ba5de-90c1-45b8-b38d-ec4edc72095a

📥 Commits

Reviewing files that changed from the base of the PR and between ca2912d and 2144bf2.

📒 Files selected for processing (1)
  • src/test/evo_deterministicmns_tests.cpp

Walkthrough

CreateProRegTxExternalCollateral now funds externally-referenced provider registration transactions with 1 * COIN instead of the full regular collateral amount. The transaction payload and signing flow remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: pastapastapasta, knst

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the test change to ProRegTx funding with external collateral.
Description check ✅ Passed The description is related to the ProRegTx funding test fix and issue #7455 follow-up.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@knst knst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2144bf2

tx.nVersion = 3;
tx.nType = TRANSACTION_PROVIDER_REGISTER;
const auto spent = FundTransaction(chainman, tx, utxos, scriptPayout, dmn_types::Regular.collat_amount);
// The collateral is external (referenced via collateralOutpoint), so this tx only needs to fund a fee.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment is useless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants