V0.12.1.x governance pr 2#950
Merged
Merged
Conversation
- This restores behavior very close to that in 12.0
- Needed to prevent the forking problem currently being seen on
testnet between online and offline nodes
- This is expected to be a temporary fix while we develop a
long-term solution for this problem
- This is needed to allow fixing RPC tests so that they wait until
the nodes are fully synced before performing tests
|
I'm not sure if that is enough but definitely looks like a good step forward. |
|
utACK a9ddf6f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the forking issue on testnet and restores miner rewards for superblocks. The RPC tests have also been fixed so that tests do not run until masternode syncing is complete. Only the tests which failed with the governance fix have had the syncing change applied because it does increase the time needed for the tests by a bit.
Note: I'm including both the governance fixes and RPC test fixes in one PR so as not to create an order dependence between 2 PR's, especially since there is already a backlog of unmerged PR's at the moment.