Skip to content

fix: typescript definitions#284

Merged
markin-io merged 1 commit into
masterfrom
fix/typings
Jun 6, 2023
Merged

fix: typescript definitions#284
markin-io merged 1 commit into
masterfrom
fix/typings

Conversation

@markin-io

@markin-io markin-io commented Jun 6, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

Fixed issue with the type system export and addressed some typings bugs

What was done?

  • Fixed bugs in existing typings systems
  • Made types accessible in both *.ts and *.d.ts (Got rid of export declare module and exported types directly from the root index.d.ts)
  • Added basic tests for exported type definitions

How Has This Been Tested?

  • CI
  • Tested imports in wallet-lib's *.d.ts definitions
  • Tested imports in SDK TS code

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@markin-io markin-io changed the title test: add tests for typings and fix bugs fix: typescript definitions Jun 6, 2023

@jawid-h jawid-h left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me 👍

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants