Skip to content

fix: missing internal types for transaction and block#286

Merged
markin-io merged 2 commits into
masterfrom
fix/add-missing-type-definitions
Jun 7, 2023
Merged

fix: missing internal types for transaction and block#286
markin-io merged 2 commits into
masterfrom
fix/add-missing-type-definitions

Conversation

@markin-io

@markin-io markin-io commented Jun 7, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

Fix adds missing declarations for the internal types of Block and Transaction, and also fixes a few inconsistencies in the Transaciton type itself

What was done?

How Has This Been Tested?

  • SDK build and types test
  • Wallet lib types test

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@markin-io markin-io changed the title fix: Transaction types fix: missing internal types Jun 7, 2023
@markin-io markin-io changed the title fix: missing internal types fix: missing internal types for transaction and block Jun 7, 2023

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants