Skip to content

fix: update to new devnet naming and versioning system (0.18 Core)#158

Closed
HashEngineering wants to merge 2 commits into
masterfrom
feature-devnet-versions
Closed

fix: update to new devnet naming and versioning system (0.18 Core)#158
HashEngineering wants to merge 2 commits into
masterfrom
feature-devnet-versions

Conversation

@HashEngineering

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

In the latest Core 0.18, a devnet versioning system was added. This changes the devnet genesis block, the user agent and when DGW is used.

Source: dashpay/dash#4685

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering self-assigned this Feb 17, 2022
Comment thread core/src/main/java/org/bitcoinj/params/DevNetParams.java Outdated
@HashEngineering

Copy link
Copy Markdown
Collaborator Author

Before this is finished, I should try to get the difficulty algo working again for devnets.

@Syn-McJ Syn-McJ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering

Copy link
Copy Markdown
Collaborator Author

This PR needs to wait until the similar PR is merged in Dash Core.

@HashEngineering

Copy link
Copy Markdown
Collaborator Author

This change was not added back into Core 18. Let us close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants