Skip to content

feat(ui): Present view controllers from auth manager on top of the current context#498

Merged
pankcuf merged 1 commit into
developfrom
feature/improve-auth-manager
Jul 11, 2023
Merged

feat(ui): Present view controllers from auth manager on top of the current context#498
pankcuf merged 1 commit into
developfrom
feature/improve-auth-manager

Conversation

@tikhop

@tikhop tikhop commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Currently we presenting view controller from auth manager inside the current view controller and it leads to wrong layout of the presenting controller. In this PR we made a small fix in order to present the presenting view controller on top of the screen.

What was done?

  • Set modalPresentationStyle property of presenting view controller to UIModalPresentationOverFullScreen

How Has This Been Tested?

Manually

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@tikhop
tikhop requested a review from pankcuf July 11, 2023 13:51
@pankcuf
pankcuf merged commit b610b20 into develop Jul 11, 2023
@pankcuf
pankcuf deleted the feature/improve-auth-manager branch July 12, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants