Skip to content

Fix/ed25519 hashing scheme #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pankcuf merged 2 commits into from
Jul 11, 2023
Merged

Fix/ed25519 hashing scheme #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d75e813
fix: hashing scheme for platform node key id
pankcuf Jul 11, 2023
aa68a00
chore: shorthand for platform node hash
pankcuf Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DashSync/shared/Models/Derivation Paths/DSAuthenticationKeysDerivationPath.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ + (instancetype)blockchainIdentityECDSAKeysDerivationPathForChain:(DSChain *)cha
+ (instancetype)blockchainIdentityBLSKeysDerivationPathForChain:(DSChain *)chain {
UInt256 indexes[] = {uint256_from_long(FEATURE_PURPOSE), uint256_from_long(chain_coin_type(chain.chainType)), uint256_from_long(FEATURE_PURPOSE_IDENTITIES), uint256_from_long(FEATURE_PURPOSE_IDENTITIES_SUBFEATURE_AUTHENTICATION), uint256_from_long(1)};
BOOL hardenedIndexes[] = {YES, YES, YES, YES, YES};
DSAuthenticationKeysDerivationPath *blockchainIdentityBLSKeysDerivationPath = [DSAuthenticationKeysDerivationPath derivationPathWithIndexes:indexes hardened:hardenedIndexes length:5 type:DSDerivationPathType_MultipleUserAuthentication signingAlgorithm:/*[chain activeBLSType]*/KeyKind_BLS reference:DSDerivationPathReference_BlockchainIdentities onChain:chain];
DSAuthenticationKeysDerivationPath *blockchainIdentityBLSKeysDerivationPath = [DSAuthenticationKeysDerivationPath derivationPathWithIndexes:indexes hardened:hardenedIndexes length:5 type:DSDerivationPathType_MultipleUserAuthentication signingAlgorithm:KeyKind_BLS reference:DSDerivationPathReference_BlockchainIdentities onChain:chain];
blockchainIdentityBLSKeysDerivationPath.shouldStoreExtendedPrivateKey = YES;
blockchainIdentityBLSKeysDerivationPath.usesHardenedKeys = YES;
return blockchainIdentityBLSKeysDerivationPath;
Expand Down
4 changes: 3 additions & 1 deletion DashSync/shared/Models/Masternode/DSLocalMasternode.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,9 @@ - (void)registrationTransactionFundedByAccount:(DSAccount *)fundingAccount toAdd
} else {
platformNodeKey = [platformNodeKeysDerivationPath privateKeyAtIndex:self.platformNodeWalletIndex fromSeed:seed];
}
UInt160 platformNodeID = [DSKeyManager publicKeyData:platformNodeKey].hash160;

UInt256 platformNodeHash = [DSKeyManager publicKeyData:platformNodeKey].SHA256;
UInt160 platformNodeID = *(UInt160 *)&platformNodeHash;

OpaqueKey *ownerKey;
if (self.ownerWalletIndex == UINT32_MAX) {
Expand Down