Skip to content

refactor: hpmn rename to evo for DIP-0028#145

Merged
thephez merged 4 commits into
masterfrom
dip28_hpmn_rename_evo
Oct 9, 2023
Merged

refactor: hpmn rename to evo for DIP-0028#145
thephez merged 4 commits into
masterfrom
dip28_hpmn_rename_evo

Conversation

@ogabrielides

Copy link
Copy Markdown
Contributor

DIP-0028 needs to be aligned with implementation (dashpay/dash#5508)

@ogabrielides
ogabrielides requested a review from thephez October 3, 2023 20:18
@ogabrielides ogabrielides changed the title refactor: hpmn rename to evofor DIP-0028 refactor: hpmn rename to evo for DIP-0028 Oct 3, 2023
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
@ogabrielides
ogabrielides force-pushed the dip28_hpmn_rename_evo branch from d489907 to 671d25b Compare October 4, 2023 13:04
@ogabrielides
ogabrielides requested a review from UdjinM6 October 4, 2023 13:05
UdjinM6
UdjinM6 previously approved these changes Oct 4, 2023

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thephez thephez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly capitalization changes with a few other adjustments

Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Co-authored-by: thephez <thephez@users.noreply.github.com>
Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
@ogabrielides
ogabrielides requested a review from UdjinM6 October 5, 2023 10:47
@ogabrielides

Copy link
Copy Markdown
Contributor Author

Note: dashpay/FAQs#10 should be merged first.

UdjinM6
UdjinM6 previously approved these changes Oct 5, 2023

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thephez thephez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a couple 🙂

Comment thread dip-0028.md Outdated
Comment thread dip-0028.md Outdated
Co-authored-by: thephez <thephez@users.noreply.github.com>

@thephez thephez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thephez
thephez merged commit 920b7f8 into master Oct 9, 2023
@thephez
thephez deleted the dip28_hpmn_rename_evo branch October 9, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants