Skip to content

Remove attemptNum from CLSIG and fix description of sig verification#39

Merged
thephez merged 1 commit into
masterfrom
codablock-dip8-clsig
Jan 24, 2019
Merged

Remove attemptNum from CLSIG and fix description of sig verification#39
thephez merged 1 commit into
masterfrom
codablock-dip8-clsig

Conversation

@codablock

@codablock codablock commented Jan 23, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@codablock codablock mentioned this pull request Jan 23, 2019
Merged
@UdjinM6

UdjinM6 commented Jan 23, 2019

Copy link
Copy Markdown
Contributor

Should also fix Signing attempts session I guess.

@codablock

codablock commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

@UdjinM6 not sure I understand...can you explain more?

@UdjinM6

UdjinM6 commented Jan 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

s/session/section/ 🙈

Signing attempts section of this DIP mentions attemptNum a lot and should be adjusted accordingly since we are not using it anymore.

@codablock

codablock commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

The "Signing attempts" phase will still use attemptNum, it's just the finalization phase that didn't need it. In the finalization phase, a new signing session is started with the prevBlockHash and blockHash of the last successful attempt, but for this the attemptNum is not needed anymore.

@UdjinM6

UdjinM6 commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

Ah, I see now. Thanks!

@thephez
thephez merged commit 9e97430 into master Jan 24, 2019
@thephez
thephez deleted the codablock-dip8-clsig branch January 24, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock @UdjinM6 @thephez