Skip to content

New transitions doesn't have getter/setter methods #3871

Description

@owl352

Currently rs-dpp:4.0.0-rc.2 doesn't contains getters and setters for shield transitions. We have public field in V0 structs, but transition enum doesn't have access to this fields

Expected Behavior

let transition = ShieldTransition::V0(ShieldTransitionV0 {
            inputs,
            actions,
            amount,
            anchor: js_anchor.to_vec().try_into().unwrap(),
            proof: js_proof.to_vec(),
            binding_signature: js_bindings_signature.to_vec().try_into().unwrap(),
            fee_strategy,
            user_fee_increase,
            input_witnesses,
        }));

transition.set_actions(vec![some_SerializedAction, another_SerializedAction, ...]);
transition.set_amount(11111111);
...

Current Behavior

Currently we have acces from ShieldTransition to inputs and input_witnesses

Possible Solution

Implement getters and setters for pub enum ShieldTransition and other new transitions, which doesn't have this

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions