Skip to content

feat(dpp): implement hashed ECDSA key type#141

Merged
shumkov merged 6 commits into
v0.22-devfrom
key-type-2
Dec 22, 2021
Merged

feat(dpp): implement hashed ECDSA key type#141
shumkov merged 6 commits into
v0.22-devfrom
key-type-2

Conversation

@shuplenkov

@shuplenkov shuplenkov commented Dec 17, 2021

Copy link
Copy Markdown

Issue being fixed or feature implemented

In order to support masternode owner key which hash160 of ECDSA we need to introduce a new identity public key type 2 and support it for singing and verification of State Transitions

What was done?

Added new key type 2.

How Has This Been Tested?

With tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.22.0 milestone Dec 17, 2021
Comment thread packages/js-dpp/test/unit/identity/IdentityPublicKey.spec.js

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread packages/js-dpp/schema/identity/publicKey.json
Comment thread packages/js-dpp/schema/identity/publicKey.json Outdated

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov
shumkov merged commit f02bfc4 into v0.22-dev Dec 22, 2021
@shumkov
shumkov deleted the key-type-2 branch December 22, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants