chore(release): update changelog and bump version to 0.25.7#1507
Closed
shumkov wants to merge 1 commit into
Closed
chore(release): update changelog and bump version to 0.25.7#1507shumkov wants to merge 1 commit into
shumkov wants to merge 1 commit into
Conversation
bfoss765
added a commit
to bfoss765/platform
that referenced
this pull request
Jul 12, 2026
…ed scan persists CoinJoin spends (dashpay#1507) The interim `debit_router_omitted_asset_lock_spends` ran at step 4b right after broadcast and did a bare in-memory `utxos.remove()` + `update_balance()` with no changeset queued. Because it stripped the spent CoinJoin/DashPay UTXO before dash-spv's async scan, the router- fixed `check_core_transaction` found no UTXO, emitted no TransactionRecord for that account, so `derive_spent_utxos` saw empty `input_details` and the deletion was never persisted — the dashpay#1507 balance re-inflates on the next restart. Now that the rust-dashcore router fix is vendored (CoinJoin + DashpayReceivingFunds + DashpayExternalAccount in `get_relevant_account_types(AssetLock)`), the normal pipeline debits and persists these spends: the scan produces a record whose `input_details` cover the spent outpoints, flowing through `WalletEvent::TransactionDetected` -> `core_bridge::derive_spent_utxos` -> the persister, surviving restart. Remove the mitigation and its call site. Replace the now-moot `broadcast_mitigation_and_router_fix_do_not_double_debit` test with `router_fix_records_spent_coinjoin_input_for_persistence`, which asserts the router-fixed scan emits a CoinJoin record whose input_details resolve to the spent outpoint (the exact data the persister deletes by) — directly covering the persistence gap the reviewer flagged. Existing `router_fix_debits_coinjoin_asset_lock_spend_on_rescan` continues to cover the in-memory debit + no-reinflation on rescan. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only