Skip to content

feat!: withdrawals finalization - #1601

Merged
shumkov merged 150 commits into
v1.0-devfrom
feat/withdrawalFinalization
Feb 6, 2024
Merged

feat!: withdrawals finalization#1601
shumkov merged 150 commits into
v1.0-devfrom
feat/withdrawalFinalization

Conversation

@markin-io

@markin-io markin-io commented Nov 27, 2023 •
edited by shumkov
Loading

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Finished withdrawal part of the bridging functionality between core and platform

What was done?

Drive-ABCI

  • Handling of the core TX signing and broadcasting
  • Handling of the withdrawal document status updates (queued, pooled, broadcasted, complete, expired)

Tenderdash

  • Reworked logic of signing of the vote extensions to support withdrawal request id

JS-SDK

  • Added functionality to withdraw credits

How Has This Been Tested?

  • Added e2e test in platform-test-suite
  • Extra unit and integration tests in other packages

Breaking Changes

The initial state is changed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

QuantumExplorer and others added 13 commits November 21, 2023 18:04
@markin-io
markin-io force-pushed the feat/withdrawalFinalization branch from c6e019f to de551ff Compare December 4, 2023 15:09
@markin-io
markin-io force-pushed the feat/withdrawalFinalization branch from de551ff to 56f1d1b Compare December 4, 2023 17:13
markin-io and others added 14 commits December 5, 2023 13:14
@markin-io
test(rs-drive-abci): cover COMPLETE statuses of withdrawals
a7ada91
@markin-io
fix(wasm-dpp): missing data trigger errors
0e26221
@markin-io
test(platform-test-suite): test that regular identities cannot initia…
21f18e7 
…te withdrawals
@markin-io
wip: add loop to check balance
a3e1ea7
@markin-io
feat(rs-drive-abci): sign, verify and broadcast asset unlock tx
cea5cb8
@markin-io
fix(rs-drive-abci): every node sends asset unlock transactions
1b491f6
@markin-io
fix(rs-drive-abci): failing send_raw_transaction affects finalize_block
8ce3989
@markin-io
fix(rs-drive-abci): wrong QuorumHash::hash
e8cc763
@ogabrielides
fix(rs-drive-abci): Reverse quorum_hash
1abdcc2
@ogabrielides
fix(rs-drive-abci): partially DIP-7 implementation for asset unlock
b3ae49b
@ogabrielides
wip: improve vote extension construction
14409ba
@markin-io
feat(rs-drive-abci): assetunlock sighash
067dfdd
@markin-io
wip(test-suite): fix initial balance
b5a34ac
@markin-io
wip(drive): sign raw msg vote extension
f8a3818
QuantumExplorer
QuantumExplorer requested changes Feb 5, 2024
View reviewed changes
Comment thread .../state_transition/state_transitions/identity/identity_credit_withdrawal_transition/v0/mod.rs Outdated
Comment thread packages/rs-platform-version/src/version/drive_abci_versions.rs Outdated
Comment thread ...latform_events/withdrawals/append_signatures_and_broadcast_withdrawal_transactions/v0/mod.rs
Comment thread ...latform_events/withdrawals/append_signatures_and_broadcast_withdrawal_transactions/v0/mod.rs Outdated
Comment thread ...latform_events/withdrawals/append_signatures_and_broadcast_withdrawal_transactions/v0/mod.rs Outdated
Comment thread packages/rs-drive/src/drive/identity/withdrawals/documents.rs Outdated
Comment thread packages/rs-drive/src/drive/identity/withdrawals/documents.rs Outdated
Comment thread ...s/rs-drive/src/state_transition_action/identity/identity_credit_withdrawal/v0/transformer.rs Outdated
Comment thread packages/rs-drive-abci/src/rpc/core.rs Outdated
Comment thread ...-abci/src/execution/platform_events/withdrawals/update_broadcasted_withdrawals_status/mod.rs Outdated
shumkov
shumkov requested changes Feb 6, 2024
View reviewed changes
Comment thread packages/js-dash-sdk/src/SDK/Client/Platform/methods/identities/creditWithdrawal.ts
shumkov
shumkov requested changes Feb 6, 2024
View reviewed changes
Comment thread packages/platform-test-suite/test/e2e/withdrawals.spec.js
QuantumExplorer
QuantumExplorer requested changes Feb 6, 2024
View reviewed changes
Comment thread .../state_transition/state_transitions/identity/identity_credit_withdrawal_transition/v0/mod.rs
Comment thread ...abci/src/execution/platform_events/withdrawals/update_broadcasted_withdrawal_statuses/mod.rs Outdated
Comment thread ...dentity/withdrawals/document/fetch_up_to_100_oldest_withdrawal_documents_by_status/v0/mod.rs Outdated
Comment thread .../withdrawals/transaction/index/add_update_next_withdrawal_transaction_index_operation/mod.rs Outdated
shumkov
shumkov approved these changes Feb 6, 2024
View reviewed changes

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, everyone! 👍

@shumkov
shumkov merged commit 9591752 into v1.0-dev Feb 6, 2024
@shumkov
shumkov deleted the feat/withdrawalFinalization branch February 6, 2024 14:47
@shumkov shumkov changed the title feat(drive): withdrawals finalization feat: withdrawals finalization Feb 6, 2024
@shumkov shumkov changed the title feat: withdrawals finalization feat!: withdrawals finalization Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lklimek lklimek lklimek left review comments
@shumkov shumkov shumkov approved these changes
@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes
@antouhou antouhou Awaiting requested review from antouhou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@markin-io @shumkov @lklimek @QuantumExplorer @ogabrielides