fix(drive-abci)!: internal error if vote extension block is already committed

[shumkov]

Issue being fixed or feature implemented

2024-01-10T16:26:53.025676Z ERROR abci{endpoint="VerifyVoteExtension" request_id="a1db78ec-794f-4e94-8cbb-3d223c53704b" height=80 round=0}: tenderdash_abci::application: sending ABCI exception response=Exception(ResponseException { error: "execution: platform corrupted code execution error: block execution context must be set in block begin handler for verify vote extension" })
2024-01-10T16:26:53.025764Z ERROR tenderdash_abci::server::generic: error processing request error="execution: platform corrupted code execution error: block execution context must be set in block begin handler for verify vote extension" request=Request { value: Some(VerifyVoteExtension(RequestVerifyVoteExtension { hash: [222, 181, 19, 70, 241, 28, 183, 10, 45, 138, 159, 41, 179, 248, 177, 105, 229, 214, 17, 170, 160, 151, 225, 0, 57, 217, 100, 193, 242, 201, 111, 111], validator_pro_tx_hash: [12, 158, 50, 43, 61, 34, 168, 103, 41, 21, 179, 50, 2, 240, 220, 76, 42, 62, 79, 114, 26, 118, 11, 117, 75, 180, 64, 239, 67, 158, 181, 215], height: 80, round: 0, vote_extensions: [] })) }

What was done?

• Reject vote extension if block already committed
• Improve logging
• validate extension height and round

How Has This Been Tested?

None

Breaking Changes

Previous blockchain data might be invalid since we could invalidate unordered vote extensions

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone