Skip to content

feat(drive): validate asset lock proof minimal value - #1667

Merged
markin-io merged 17 commits into
v1.0-devfrom
feat/minimal-asset-lock-amount
Jan 23, 2024
Merged

feat(drive): validate asset lock proof minimal value#1667
markin-io merged 17 commits into
v1.0-devfrom
feat/minimal-asset-lock-amount

Conversation

@markin-io

@markin-io markin-io commented Jan 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Feature adds validation for minimal asset lock amount

What was done?

  • Validate minimal asset lock amount for identity create
  • Validate minimal asset lock amount for identity top up
  • Added test to platform-test-suite

How Has This Been Tested?

New test in platform-test-suite

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io
markin-io marked this pull request as ready for review January 11, 2024 17:33
@markin-io
markin-io marked this pull request as draft January 11, 2024 17:34
@markin-io
markin-io marked this pull request as ready for review January 16, 2024 20:03
@markin-io markin-io added this to the v1.0.0 milestone Jan 16, 2024
shumkov
shumkov requested changes Jan 17, 2024
View reviewed changes
Comment thread packages/rs-dpp/src/errors/consensus/basic/basic_error.rs Outdated
shumkov
shumkov reviewed Jan 18, 2024
View reviewed changes
Comment thread packages/platform-test-suite/test/functional/platform/Identity.spec.js Outdated
shumkov
shumkov previously approved these changes Jan 18, 2024
View reviewed changes

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

QuantumExplorer
QuantumExplorer requested changes Jan 22, 2024
View reviewed changes
Comment thread .../src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs Outdated
QuantumExplorer
QuantumExplorer requested changes Jan 23, 2024
View reviewed changes
Comment thread ...pp/src/state_transition/state_transitions/identity/identity_create_transition/methods/mod.rs Outdated
Comment thread ...dpp/src/state_transition/state_transitions/identity/identity_topup_transition/methods/mod.rs Outdated
Comment thread ...pp/src/state_transition/state_transitions/identity/identity_create_transition/methods/mod.rs Outdated
Comment thread ...dpp/src/state_transition/state_transitions/identity/identity_topup_transition/methods/mod.rs Outdated
Comment thread ...p/src/state_transition/state_transitions/identity/identity_topup_transition/v0/v0_methods.rs Outdated
@markin-io
markin-io merged commit 30929ea into v1.0-dev Jan 23, 2024
@markin-io
markin-io deleted the feat/minimal-asset-lock-amount branch January 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes
@shumkov shumkov shumkov left review comments
@antouhou antouhou Awaiting requested review from antouhou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@markin-io @shumkov @QuantumExplorer