chore(dashmate)!: adjust consensus params and enable re-check - #1669
Merged
Conversation
QuantumExplorer
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We use default consensus timeouts for local and 0.24-based values for testnet. Re-check is not set so it's initializing as false. We have already more or less tested values and we need re-check to clean up mempool from unpaid invalid txs
What was done?
How Has This Been Tested?
On devnet and locally by @lklimek
Breaking Changes
It will be a breaking change for any network since genesis params are changed
Checklist:
For repository code-owners and collaborators only