Skip to content

chore(dashmate)!: adjust consensus params and enable re-check - #1669

Merged
shumkov merged 1 commit into
v1.0-devfrom
feat/dashmate/add-consenus-params
Jan 12, 2024
Merged

chore(dashmate)!: adjust consensus params and enable re-check#1669
shumkov merged 1 commit into
v1.0-devfrom
feat/dashmate/add-consenus-params

Conversation

@shumkov

@shumkov shumkov commented Jan 12, 2024

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

We use default consensus timeouts for local and 0.24-based values for testnet. Re-check is not set so it's initializing as false. We have already more or less tested values and we need re-check to clean up mempool from unpaid invalid txs

What was done?

  • set consensus timeouts
  • adjust some other values
  • enable re-check

How Has This Been Tested?

On devnet and locally by @lklimek

Breaking Changes

It will be a breaking change for any network since genesis params are changed

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jan 12, 2024
@shumkov
shumkov merged commit 31f84e4 into v1.0-dev Jan 12, 2024
@shumkov
shumkov deleted the feat/dashmate/add-consenus-params branch January 12, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants