Skip to content

fix(dapi): internal errors if broadcasting failed - #1673

Merged
shumkov merged 4 commits into
v1.0-devfrom
fix/dapi/socket-hand-up
Jan 16, 2024
Merged

fix(dapi): internal errors if broadcasting failed#1673
shumkov merged 4 commits into
v1.0-devfrom
fix/dapi/socket-hand-up

Conversation

@shumkov

@shumkov shumkov commented Jan 16, 2024

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

When Tenderdash under heavy load DAPI fails to connect to it to broadcast a state transition and fails with the socket hang up error. We also need to handle a new check tx timeout introduced in tenderdash.

What was done?

  • handle the socket hang up error and return the unavailable error code.
  • handle broadcast confirmation not received error
  • update tests

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jan 16, 2024
@shumkov shumkov changed the title fix: socket hang up error on broadcasting fix(dapi): socket hang up error on broadcasting Jan 16, 2024
markin-io
markin-io previously approved these changes Jan 16, 2024

@markin-io markin-io left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shumkov shumkov changed the title fix(dapi): socket hang up error on broadcasting fix(dapi): internal errors if broadcasting failed Jan 16, 2024
pshenmic
pshenmic previously approved these changes Jan 16, 2024

@pshenmic pshenmic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@shumkov
shumkov merged commit 77febff into v1.0-dev Jan 16, 2024
@shumkov
shumkov deleted the fix/dapi/socket-hand-up branch January 16, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants